Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest using fully qualified namespace for System.ComponentModel.DefaultValue #89

Open
michaelcfanning opened this issue Jan 8, 2019 · 0 comments

Comments

@michaelcfanning
Copy link
Member

As it happens, System.ComponentModel pulls in names that collide with terms such as 'EnumConverter' that are likely to be utilized by projects that consume JSON.NET.

An easy fix is to use the fully qualified name in the code emit. This will prevent others from having to use fully qualified names in things like attribute hint arguments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant