Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Rollup task #136

Open
Thisen opened this issue Jun 20, 2019 · 7 comments
Open

Proposal: Rollup task #136

Thisen opened this issue Jun 20, 2019 · 7 comments

Comments

@Thisen
Copy link
Contributor

Thisen commented Jun 20, 2019

I propose adding a task for Rollup.

Rollup is used by many to optimize their libraries and is a solid tool. Webpack doesn't have esm support yet.

@anikethsaha
Copy link
Contributor

yeah, it would be great to have it !.
I never used rollup but it seems they support config files so I guess it can be pretty much similar to the webpack tasks!

@kenotron
Copy link
Member

kenotron commented Jul 2, 2019

Webpack DEFINITELY has esm support, but rollup is a good task to have. Although I don't want to make the mistake of making an impression that people need to have wrappers on every tool to get productive with this library. Perhaps I should have a "execTask" and a "nodeTask" for out of box flexibility?

@kenotron kenotron self-assigned this Jul 2, 2019
@anikethsaha
Copy link
Contributor

like execTask or nodeTask to run other commands (CLI cmds) or to run other tasks?
maybe spawnTask kind of thing may work ! not sure though

@Thisen
Copy link
Contributor Author

Thisen commented Jul 3, 2019

@kenotron I wasnt clear in my description, what I meant by es modules support was that Webpack doesnt have libraryTarget: 'esm', as described here: webpack/webpack#2933

@Thisen
Copy link
Contributor Author

Thisen commented Jul 3, 2019

I can also contribute to those tasks, if needed.

@kenotron
Copy link
Member

kenotron commented Jul 4, 2019

oh yes, for that you need rollup! for sure! I'm a bit busy working on the build cache stuff ATM... if you want to contrib, you'll get to see it in the codebase faster :) Much like the eslint task :P

@github-actions
Copy link

github-actions bot commented Mar 9, 2020

Issues seem to have gone stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants