Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AzureIdentityAccessTokenProvider incorrect docs #76

Closed
Tiefseetauchner opened this issue Apr 26, 2023 · 1 comment · Fixed by #77
Closed

AzureIdentityAccessTokenProvider incorrect docs #76

Tiefseetauchner opened this issue Apr 26, 2023 · 1 comment · Fixed by #77

Comments

@Tiefseetauchner
Copy link

AzureIdentityAccessTokenProvider incorrectly proclaims it's association with IAuthenticationProvider, to the detrement of trying to use it.

In short, the docs are wrong

namespace Microsoft.Kiota.Authentication.Azure;
/// <summary>
/// Provides an implementation of <see cref="IAuthenticationProvider"/> for Azure.Identity.
/// </summary>
public class AzureIdentityAccessTokenProvider : IAccessTokenProvider, IDisposable

It does, in fact, not provide an implementation of IAuthenticationProvider for Azure.Identity. I don't know which is supposed to be right, the code or the docs, so I'm leaving it in your capable hands to decide.

Thanks, Lena

@andrueastman andrueastman mentioned this issue Apr 26, 2023
@andrueastman
Copy link
Member

Thanks for raising this @Tiefseetauchner

AzureIdentityAccessTokenProvider is an implementation of IAccessTokenProvider for Azure.Identity. and not IAuthenticationProvider

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants