Streams returned from the HttpClientRequestAdapter cannot be used

[calebkiage]

Streams returned from HttpClientRequestAdapter methods like SendPrimitiveAsync<Stream> cannot be used. The methods return disposed streams. I believe the culprit is the new DrainAsync method.

[baywet]

Ah this is probably a shortcoming on my side when I implemented this. The fact that it's a finally means it always runs the drain async.

kiota-http-dotnet/src/HttpClientRequestAdapter.cs

Line 220 in 8de56f6

await DrainAsync(response);

We probably have avenues opportunities here:

• Clone the stream into a memory stream, and return that memory stream instead. This might lead to higher memory usage.
• Add a condition in the finally. Consumers might lock the connections if they don't dispose the stream in that case.

Thoughts?

[andrueastman]

I believe there are scenarios where the response content may be large and consumers would not want/accept to load the entire stream into memory in some scenarios. On a side note, we should also probably add support for passing the HttpCompletionOption to the httpClient as well.

I think adding a condition for streams should be okay as we already call ReadAsStreamAsync() here for streams so the connection should be released as we have read the response body.

kiota-http-dotnet/src/HttpClientRequestAdapter.cs

Line 158 in 8de56f6

return (ModelType)(await response.Content.ReadAsStreamAsync() as object);

[baywet]

Makes sense, thanks for the input. I'm not sure what would be the impact for the completion options (worried about side effects on the service side). Would one of you be so kind to submit a PR to add the condition to the finally please?