Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove async suffix for request adapter methods #992

Closed
baywet opened this issue Dec 11, 2023 · 1 comment · Fixed by #1087
Closed

remove async suffix for request adapter methods #992

baywet opened this issue Dec 11, 2023 · 1 comment · Fixed by #1087
Assignees
@koros
Labels
WIP
Milestone
Kiota v1.12

Comments

@baywet
Copy link
Member

baywet commented Dec 11, 2023

all other methods (generated, authentication infrastructure) don't have the suffix, we should align for consistency
@baywet baywet added this to the Kiota v1.10 milestone Dec 11, 2023
@baywet baywet self-assigned this Dec 11, 2023
@sebastienlevert
Copy link

Agree, async is weird in typescript IMO.

@baywet baywet modified the milestones: Kiota v1.10, Kiota v1.11 Jan 11, 2024
@baywet baywet modified the milestones: Kiota v1.11, Kiota v1.12 Feb 1, 2024
@sebastienlevert sebastienlevert assigned koros and unassigned baywet Feb 1, 2024
@koros koros self-assigned this Feb 27, 2024
This was referenced Feb 27, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@koros koros

Labels
WIP
Projects
Kiota
Archived in project
Milestone
Kiota v1.12
Development

Successfully merging a pull request may close this issue.

remove async suffix for request adapter methods microsoft/kiota-typescript
3 participants
@koros @sebastienlevert @baywet