Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generated client does not compile with Member with the same signature already declared. #2209

Closed
SilasKenneth opened this issue Jan 30, 2023 · 1 comment · Fixed by #2213
Closed

Generated client does not compile with Member with the same signature already declared. #2209

SilasKenneth opened this issue Jan 30, 2023 · 1 comment · Fixed by #2213
Assignees
@baywet
Labels
fixed generator Issues or improvements relater to generation capabilities. type:bug A broken experience WIP
Milestone
Kiota v1

Comments

@SilasKenneth
Copy link
Member

SilasKenneth commented Jan 30, 2023 •
edited

File/Class with issue.

Generated/Feeds/WithFormat/WithFormatRequestBuuilder

image

How to reproduce.

  1. Try to generate a client for PeerTube
  2. Compile the generated client.

Environment:
OS: Windows 11.
Dotnet 7.0.102
@baywet baywet self-assigned this Jan 30, 2023
@baywet baywet added type:bug A broken experience generator Issues or improvements relater to generation capabilities. labels Jan 30, 2023
@baywet baywet added this to the Kiota GA milestone Jan 30, 2023
@baywet baywet mentioned this issue Jan 30, 2023
Merged
@baywet
Copy link
Member

baywet commented Jan 30, 2023

Thanks for reporting this. Kiota was effectively ignoring every.doted.subsegement in a path segment, this was done to facilitate odata method names like /me/microsoft.graph.foo() to avoid generating too deep of a namespacing but it was wrong and could lead to collisions like the one you've experienced.
I've added a fix for that in #2213

@baywet baywet added the fixed label Jan 30, 2023
@andrueastman andrueastman mentioned this issue Feb 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@baywet baywet

Labels
fixed generator Issues or improvements relater to generation capabilities. type:bug A broken experience WIP
Projects
None yet
Milestone
Kiota v1
Development

Successfully merging a pull request may close this issue.

- fixes a bug in namespace name generation microsoft/kiota
2 participants
@baywet @SilasKenneth