Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introspection.py method "extract_args_from_signature" contains dead CLI 2.0 code #29

Closed
tjprescott opened this issue Sep 27, 2017 · 1 comment
Milestone

Comments

@tjprescott
Copy link
Member

https://github.com/Microsoft/knack/blob/master/knack/introspection.py#L71

This makes reference to the no_wait_param which is used by CLI 2.0 to expose --no-wait and is pretty CLI specific. Regardless, all of this code is dead because there's no good way to pass anything into this method, so the default branch is always triggered.

My recommendation would be to remove this code.

@tjprescott
Copy link
Member Author

Within the CLI, I add this parameter back in "create_command". It is added to the args after "extract_args_from_signature". I add both --no-wait and --yes here to keep things easier to maintain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants