Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: spawn EINVAL with Node v20.12.2 #733

Closed
fcaminada opened this issue Apr 18, 2024 · 4 comments · Fixed by #732
Closed

Error: spawn EINVAL with Node v20.12.2 #733

fcaminada opened this issue Apr 18, 2024 · 4 comments · Fixed by #732

Comments

@fcaminada
Copy link
Contributor

Describe the bug
Node v20.12.2 contains a security update that prohibits spawning "cmd" or "bat" processes without the "shell" option enabled.

https://nodejs.org/en/blog/vulnerability/april-2024-security-releases-2

Since NpmScriptRunner does not use "shell" option, spawning a "npm" command fails with error "EINVAL" on Windows.

To Reproduce

  1. Update NodeJS to v20.12.2 on Windows
    1. Run the lage command on a lage-enabled folder.

Expected behavior
Lage builds successfully.

Environment/Troubleshooting
System:
OS: Windows 10 10.0.22631
CPU: (16) x64 AMD EPYC 7763 64-Core Processor
Memory: 36.24 GB / 63.95 GB
Binaries:
Node: 20.12.2 - C:\Program Files\nodejs\node.EXE
npm: 10.5.0 - C:\Program Files\nodejs\npm.CMD
pnpm: 8.15.3 - C:\git\P\node_modules.bin\pnpm.CMD
Utilities:
Git: 2.44.0.
Curl: 8.4.0 - C:\Windows\system32\curl.EXE
SDKs:
Windows SDK:
AllowDevelopmentWithoutDevLicense: Enabled
Versions: 10.0.19041.0, 10.0.20348.0, 10.0.22621.0
IDEs:
VSCode: 1.88.0 - C:\Program Files\Microsoft VS Code\bin\code.CMD
Visual Studio: 17.9.34728.123 (Visual Studio Enterprise 2022), 16.11.34729.46 (Visual Studio Enterprise 2019)
Browsers:
Chrome: 124.0.6367.60
Edge: Chromium (123.0.2420.81)
Internet Explorer: 11.0.22621.1

@fcaminada
Copy link
Contributor Author

Will be fixed in #732

@ecraig12345
Copy link
Member

Released in 2.7.14

@ecraig12345
Copy link
Member

Also in 1.10.0

@fcaminada
Copy link
Contributor Author

Tested the fix and it works perfectly. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants