Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility of different diagnostic collections based on source #1088

Closed
stamblerre opened this issue Sep 5, 2020 · 4 comments
Closed

Possibility of different diagnostic collections based on source #1088

stamblerre opened this issue Sep 5, 2020 · 4 comments
Labels
diagnostics feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities
Milestone

Comments

@stamblerre
Copy link

I was wondering if you had considered allowing language servers to have separate diagnostic collections, much like VS Code extensions. In the case of the Go language server, some types of diagnostics appear as files change and others are computed only when files are saved, etc. Having separate diagnostic collections would allow us to update only the relevant collections, rather than resending all of the current diagnostics + the new diagnostics.

Obviously this is something that the language server can handle without diagnostic collections, so it's certainly not a necessity, but it was something that came up for us in a discussion.

@dbaeumer
Copy link
Member

dbaeumer commented Sep 7, 2020

I understand the use case but so far now big demand for this. Would you be willing to work on a PR?

@dbaeumer dbaeumer added the help wanted Issues identified as good community contribution opportunities label Sep 7, 2020
@dbaeumer dbaeumer added this to the Backlog milestone Sep 7, 2020
@razzeee
Copy link
Contributor

razzeee commented Sep 7, 2020

I would love this, as our code to send different diagnostics is very complex at the moment.

@stamblerre
Copy link
Author

Would you be willing to work on a PR?

Unfortunately, I don't think I will be able to take this on--sorry about that!

@dbaeumer
Copy link
Member

Actually support for this got added with the new pull diagnostic. You can register different identifiers. I will close the request in favor of the support in pull.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
diagnostics feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities
Projects
None yet
Development

No branches or pull requests

3 participants