Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support GlobPattern in DocumentFilter #1781

Open
mroch opened this issue Aug 1, 2023 · 0 comments
Open

Support GlobPattern in DocumentFilter #1781

mroch opened this issue Aug 1, 2023 · 0 comments
Labels
document synchronization feature-request Request for new features or functionality
Milestone
3.18

Comments

@mroch
Copy link

mroch commented Aug 1, 2023

in the VS Code API, DocumentFilter's pattern property is a GlobPattern (docs), which supports RelativePattern. but in the LSP only string is supported.

now that RelativePattern is part of the LSP, I propose that LSP's DocumentFilter.pattern also become a GlobPattern.

at the very least, it should be a Pattern, not just a string.
@dbaeumer dbaeumer added document synchronization feature-request Request for new features or functionality labels Aug 8, 2023
@dbaeumer dbaeumer added this to the 3.18 milestone Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
document synchronization feature-request Request for new features or functionality
Projects
None yet
Milestone
3.18
Development

No branches or pull requests
2 participants
@mroch @dbaeumer