Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MetaModel: Missing Types and TraceValue vs TraceValues #1861

Closed
yxrkt opened this issue Dec 14, 2023 · 2 comments
Closed

MetaModel: Missing Types and TraceValue vs TraceValues #1861

yxrkt opened this issue Dec 14, 2023 · 2 comments
Milestone
Next

Comments

@yxrkt
Copy link

yxrkt commented Dec 14, 2023 •
edited

Message, MessageDirection, NotificationMessage, RequestMessage, ResponseMessage, and ResponseError are missing from metaModel.json.

Also a very minor discrepancy: In the spec, it is called TraceValue. In metaModel.json, it is called TraceValues.
@yxrkt yxrkt changed the title MetaModel vs Spec MetaModel: Missing Types and TraceValue vs TraceValues Dec 14, 2023
@dbaeumer
Copy link
Member

The tyes are not in the meta model since they are concepts that come from JSON-RPC and might differ depending on the JSON RPC library you are using.

I did fix the TraceValue problem.

@dbaeumer dbaeumer added this to the Next milestone Dec 14, 2023
@yxrkt
Copy link
Author

yxrkt commented Dec 15, 2023 •
edited

I just noticed URI and DocumentUri are missing. I suspect these aren't part of JSON-RPC?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Next
Development

No branches or pull requests
2 participants
@yxrkt @dbaeumer