Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CreateFile operation: How to denote directory vs file? #665

Closed
jastice opened this issue Jan 21, 2019 · 1 comment
Closed

CreateFile operation: How to denote directory vs file? #665

jastice opened this issue Jan 21, 2019 · 1 comment

Comments

@jastice
Copy link

jastice commented Jan 21, 2019

File resource changes are supposed to work on both files and folders:

File resource changes allow servers to create, rename and delete files and folders via the client. Note that the names talk about files but the operations are supposed to work on files and folders. This is in line with other naming in the Language Server Protocol (see file watchers which can watch files and folders).

But the CreateFile operation doesn't specify any way to denote whether a path is supposed to be a folder.

From #272 (comment) I gather that it should just be assumed to be a file at the moment?

This came up because we were discussing differentiating files and folders in the build server protocol at build-server-protocol/build-server-protocol#76 and wanted to stick to prior art if reasonable. Currently, we use a trailing / on the URI to denote a directory, but that is not very robust, in terms of developer ergonomics.

@dbaeumer
Copy link
Member

Agree. I will make this a dup of #272. See #272 (comment)

@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants