Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

textDocument/declaration missing a ServerCapabilities indicator #673

Closed
sam-mccall opened this issue Jan 29, 2019 · 4 comments
Closed

textDocument/declaration missing a ServerCapabilities indicator #673

sam-mccall opened this issue Jan 29, 2019 · 4 comments

Comments

@sam-mccall
Copy link
Contributor

definitionProvider, typeDefinitionProvider etc exist - is the absence of declarationProvider an oversight?

Would be useful e.g. here: https://github.com/Valloric/ycmd/blob/5996d7daf2fda93ba2a0f6cfa86cf7c99e20170a/ycmd/completers/language_server/language_server_completer.py#L59

@ioeric
Copy link

ioeric commented Mar 20, 2019

ping?

This is blocking go-to-declaration support in some clients (e.g. YCM).

@rcjsuen
Copy link
Contributor

rcjsuen commented Mar 20, 2019

Since it exists in the Microsoft/vscode-languageserver-node repository, it looks like an oversight to me.

@rcjsuen
Copy link
Contributor

rcjsuen commented Mar 20, 2019

I've opened #701 to hopefully address this.

@dbaeumer
Copy link
Member

@rcjsuen thanks. Merged the PR.

@vscodebot vscodebot bot locked and limited conversation to collaborators May 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants