Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drag and drop image files into live share #2513

Closed
kmasuyama opened this issue Jul 16, 2019 · 4 comments
Closed

Drag and drop image files into live share #2513

kmasuyama opened this issue Jul 16, 2019 · 4 comments

Comments

@kmasuyama
Copy link

Product and Version [VS/VSCode]: vscode 1.36.1
OS Version [macOS/Windows]: windows 10
Live Share Extension Version: 1.0.509

It is possible for a client to add a file into a live share-served folder by dragging and dropping into the explorer (tested successfully with markdown document). However, this does not seem to work with image files or other binary formats. File sizes are seen to increase and cannot be opened properly. I'm aware image files are not currently supported for viewing over live share [#61, #1895]. However, it would still be convenient to be able to transfer image files into the project.

File formats tried and resulting file size increase:

format size before (KB) size after (KB)
md 4 4
png 3.67 7
jpg 340 617
bmp 2.28 5
pdf 561 989
exe 1112 1975

Steps to Reproduce / Scenario:

  1. Go to explorer bar on client vscode
  2. drag and drop binary file from local filesystem
  3. go to shared folder location on host computer
  4. try to open binary file
@kmasuyama kmasuyama changed the title Add image files over live share Drag and drop image files into live share Jul 16, 2019
@Moniarchy
Copy link

Moniarchy commented Jul 16, 2019

Adding @lostintangent and @fubaduba

@Riz-waan
Copy link

This also happens with font files

@Riz-waan
Copy link

Also any idea if you guys will add a warning on drag and drop? I spent like 1 week debugging to see where the issue was.

@lostintangent
Copy link
Member

Closing this as a duplicate of #1895.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

5 participants