"Allow Guest Command Control" not obeyed in latest release

[jPinhao-Improbable]

Product and Version [VS/VSCode]: 1.41.1
OS Version [macOS/Windows]: Windows 10 Pro
Live Share Extension Version: 1.0.1456
Target Platform or Language: C# .Net Core 2.2

Steps to Reproduce / Scenario:

1. Enable Allow Guest Command Control in Live Share settings
2. Open a .Net Core project with some unit tests (tested with NUnit)
3. Start a collaboration session and have the guest join
4. Have the guest try to run a unit test via the CodeLens "Run Test" or "Debug Test" actions
5. The guest gets an error "The host doesn't allow running this command. If needed, ask them to enable it"

Note: This works again if you swap to Live Share version 1.0.1404. Executing commands from shared console, running tasks, and running Debug session defined in launch.json all seem to work in the latest version for guest.

Example CodeLens actions in question:

live-share-nocommand-logs-host.zip
live-share-nocommand-logs-guest.zip

[setaskin]

Thanks for reaching out. Looks like it is a security change. linking issue with #1550. cc: @fubaduba would you follow up for security page ?

[srivatsn]

@setaskin #1550 is about a help link whereas this issue seems to be a regression that the feature doesn't work anymore. We should take a look.

[setaskin]

@srivatsn, from what I read in #1550 I thought it has been disabled due to security. Sorry for the misunderstanding. Will take a look.

[NatoBoram]

Is there a fix for this?

[daytonellwanger]

Is this still repro'ing with latest bits?

@aletsdelarosa , could you investigate?

[NatoBoram]

Yes, I am using VSCode Insiders and Live Share with "liveshare.featureSet": "insiders". The project contains those settings :

{
  "liveshare.allowGuestDebugControl": true,
  "liveshare.allowGuestTaskControl": true,
  "liveshare.languages.allowGuestCommandControl": true,
  "liveshare.openSharedServers": false,
  "liveshare.publishWorkspaceInfo": true,
}

[Hobart2967]

Still experiencing this in 1.47.2

[jawn]

Any ETA on getting this fixed? I can imagine this blocks potential users from taking VS Live Share seriously for day to day use.

[fsalmeida]

I'm facing the same problem :(
Any workaround?

[jawn]

Will this one be picked up? @fubaduba

Issues like these reduce trust and adoption of vsls in my experience.

[PauloDanielCarneiro]

Any news about this?

[fubaduba]

Hey all, apologies for this poor experience. We are addressing this issue for the next release. Thank you for your patience.

[egaznep]

Hey all, apologies for this poor experience. We are addressing this issue for the next release. Thank you for your patience.

I tried rolling back to 1.0.1404 as suggested by @jPinhao-Improbable, however this causes some other things to break with Jupyter notebooks (haunts this bug specifically: https://github.com/microsoft/vscode-python/issues/7638). We are desperate for a fix.

Could we get an update on when will the next release appear or is the fix already present in the insiders version?

[daytonellwanger]

Hey @egaznep , let me look into this today and get back to you with an estimate. Sorry for the delay in addressing this.

[daytonellwanger]

You can expect a fix in our release next week 😊 (planned for 11/10). Thanks for your patience!

[daytonellwanger]

Fixed and released! Please update and let me know if it's now working for you 😊