Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Co-Authored-by email address not configurable/not primary #3375

Closed
robotdana opened this issue Apr 8, 2020 · 5 comments
Closed

Co-Authored-by email address not configurable/not primary #3375

robotdana opened this issue Apr 8, 2020 · 5 comments

Comments

@robotdana
Copy link

Issue Type: Bug

When logging in with github with VS Live Share to join a Live Share session, it seems to use the first email in your github account rather than the primary email to populate the Co-Authored-By in git scm tool, and doesn't appear to give you any way to change it.

This is annoying because the first email is contains my deadname, i just keep it there because it links my github account to old commits. I don't want it to be seen by collaborators, and I don't want to be surprised by it.

Please allow defining/customising what email/name to use for a live share session for the Co-Authored-By, and either allow setting a default. or at the very least use the primary email address from the github account rather than one of possibly many irrelevant email addresses. Thanks.

Extension version: 1.0.1891
VS Code version: Code 1.43.2 (0ba0ca52957102ca3527cf479571617f0de6ed50, 2020-03-24T07:34:57.037Z)
OS version: Darwin x64 19.3.0

@Moniarchy
Copy link

Thanks for opening this issue, @robotdana. Adding @fubaduba.

@mfulton26
Copy link

I was just about to report almost the same thing. In my case, I have my work email address associated with the GitHub organization we use for work. If I am participating in a Live Share for a repository in that org it would be great to default to using my work email address, otherwise it could use my primary email address (or ask me).

@fubaduba
Copy link
Contributor

Thank you for bringing this up. This seems like an easy enough update for us and we will make this change. Thank you!

@fubaduba fubaduba added this to the Oct-Dec 2022 milestone Nov 29, 2022
@fredrikaverpil
Copy link

@fubaduba yessss!!!

@fubaduba fubaduba modified the milestones: Oct-Dec 2022, Jan-Mar 2023 (uncommitted) Dec 1, 2022
@derekbekoe derekbekoe removed this from the Jan-Mar 2023 (uncommitted) milestone Mar 28, 2023
@derekbekoe
Copy link
Collaborator

We’re not able to prioritize this issue over the other higher-impact issues we receive every week, based on the votes and comments from others in the community and our understanding of the issue. We understand this may be disappointing; we've all been there, whether in this project or others we've contributed to. However, rest assured that we love your input. If you feel it deserves to stay open, then clarify your use case and contact us to let us know how severe it’s for you.

@derekbekoe derekbekoe closed this as not planned Won't fix, can't repro, duplicate, stale Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants