Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users are able to rejoin and active session if they have been removed #342

Closed
vosmith opened this issue May 9, 2018 · 6 comments
Closed

Comments

@vosmith
Copy link

vosmith commented May 9, 2018

Product and Version [VS/VSCode]:
VSCode 1.23.0
OS Version [macOS/Windows]:
Ubuntu 16.04
Live Share Extension Version:
0.3.93
Target Platform or Language [e.g. Node.js]:
Go
Steps to Reproduce / Scenario:

  1. Start a session and invite one other person
  2. Wait for that person to join the session
  3. Remove that person from the session
  4. Kindly ask the other person to re-join the session
  5. Notice that the other person succesfully rejoined the session

This might be a well-intended feature, but it felt odd from a user's perspective.

@grork
Copy link

grork commented May 9, 2018

You expect "remove" to disallow them for the entirety of the session?

@vosmith
Copy link
Author

vosmith commented May 9, 2018

Yes sir, that is what I was expecting. Take a scenario where you are running a session at a hackathon or so and you have a malicious participant. As it stands right now, you would have to create another session and re-invite everyone else to it.

My natural instincts would be to use the remove feature to block that one user without affecting the others.

@grork
Copy link

grork commented May 9, 2018

Got it! Thanks for the feedback!

@vosmith
Copy link
Author

vosmith commented May 9, 2018

Happy to help 👍 Our team is super excited about using this more often!

@IllusionMH
Copy link

Would be nice to see this feature.
Maybe in two options: "remove user" and "remove & block user", or require new link/code to rejoin session if removed (may be by accident, or when person do not has malicious intent and there were reasons to remove them temporary).

However remove & block by default won't be that bad - easy to create new session for all (if removed by accident).

@Chuxel
Copy link
Member

Chuxel commented Jun 20, 2018

Version 0.3.317 was just released that implements this request. When you remove someone from a collaboration session, they will not be able to rejoin until a new session is started.

@Chuxel Chuxel closed this as completed Jun 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants