Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't cause flag spill in gc transition end/pause expansion #124

Open
AndyAyersMS opened this issue Dec 15, 2015 · 0 comments
Open

Don't cause flag spill in gc transition end/pause expansion #124

AndyAyersMS opened this issue Dec 15, 2015 · 0 comments

Comments

@AndyAyersMS
Copy link
Member

Currently we generate the following code leading to the post-pinvoke check for GC:

    CMP32mi8 %RCX<kill>, 1, %noreg, 0, %noreg, 0, %EFLAGS<imp-def>; mem:LD4[bitcast (i64* @CaptureThreadGlobal to i32*)]
    %EDX<def> = COPY %EFLAGS
    MOV32mr %RBP, 1, %noreg, -92, %noreg, %EDX<kill>; mem:ST4[FixedStack12]
    JE_1 <BB#8>, %EFLAGS<imp-use>

We should be able to avoid the flag spill by passing the flag value to the pause, instead of the result of the flag compare.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AndyAyersMS