Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ProgressRing get's announced as image #2049

Closed
marcelwgn opened this issue Mar 1, 2020 · 1 comment · Fixed by #2065
Closed

ProgressRing get's announced as image #2049

marcelwgn opened this issue Mar 1, 2020 · 1 comment · Fixed by #2065
Assignees
@karkarl
Labels
area-Progress ProgressBar, ProgressRing bug Something isn't working team-Controls Issue for the Controls team

Comments

@marcelwgn
Copy link
Contributor

Describe the bug

Using narrator, the ProgressRing get's announced as image, not as ProgressRing with a percentage.

Steps to reproduce the bug

  1. Start Narrator
  2. Open MUXControlsTestApp
  3. Navigate to ProgressRing page
  4. Tab to the ProgressRing, oberserve that it gets anounced as image.

Expected behavior

When the progressring is indeterminate, it should get announced as "busy progressring", otherwise it should announce it's progress like the ProgressBar

Screenshots

Version Info

NuGet package version:

Latest commit on master

Windows 10 version Saw the problem?
Insider Build (19596) Yes
November 2019 Update (18363)
May 2019 Update (18362)
October 2018 Update (17763)
April 2018 Update (17134)
Fall Creators Update (16299)
Creators Update (15063)
Device form factor Saw the problem?
Desktop Yes
Mobile
Xbox
Surface Hub
IoT

Additional context

When opening the XAML Controls Gallery, the ProgressRing gets announced correctly.
@msft-github-bot msft-github-bot added the needs-triage Issue needs to be triaged by the area owners label Mar 1, 2020
@marcelwgn marcelwgn changed the title Regression: ProgressRing get's announced as image ProgressRing get's announced as image Mar 1, 2020
@ranjeshj ranjeshj added area-Progress ProgressBar, ProgressRing team-Controls Issue for the Controls team bug Something isn't working labels Mar 2, 2020
@ranjeshj
Copy link
Contributor

ranjeshj commented Mar 2, 2020

ProgressRing needs to implement an automation peer just like ProgressBar

@StephenLPeters StephenLPeters added help wanted Issue ideal for external contributors and removed needs-triage Issue needs to be triaged by the area owners help wanted Issue ideal for external contributors labels Mar 3, 2020
@karkarl karkarl mentioned this issue Mar 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karkarl karkarl

Labels
area-Progress ProgressBar, ProgressRing bug Something isn't working team-Controls Issue for the Controls team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ProgressRing Automation Peer microsoft/microsoft-ui-xaml
5 participants
@StephenLPeters @karkarl @marcelwgn @ranjeshj @msft-github-bot