-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: Vertical TabView #2194
Comments
Love that mockup @mdtauk! One thing we need to thing about: How would this go with the TabViewWidthMode.Compact when in left/right configuration? |
I would personally like that setting to be disregarded with Left or Right placement @chingucoding. You could have each tab item's width fit the content, but I don't think the pane displaying the tabs should be compact to fit the longest tab. A resizing tab pane width would be off-putting as would each tab not being the full width of the pane. The Icon only tab mode could be done, sort of resembling the NavigationView's compact mode - but with the Selected Tab having it's distinctive background colour.
This was a mockup I did when V1 of the TabView was being added to WinUI. But TabPlacement was too much to add in at that time. |
So to clarify, in Left/Right mode the TabViewWidthMode would be always Equal, regardless of setting. Seems reasonable, since it should behave more like a NavigationView in that case. My main concern with this feature is the added complexity, because we would then all of the sudden have a feature set that almost would be the same with the NavigationView (without h-nav). |
If you look at the example from that preview video, there is a new behaviour which added to the drag and re-arrange functionality that NavigationView doesn't have - there is an ability to Multi-Select tabs and move them together.
These all differentiate the two controls. I think if Edge has this, it should be included in the WinUI control. The NavigationView is for single sections of one app - the Tabs are like a multi-document scenario. |
The problem I see is not having same features like NavigationView, but rather the complexity that will get added to the TabView. And if we look at the NavigationView, you will see that it's a HUGE code base. Should TabView also move in that direction? However those are pretty cool features, and in productivity scenarios those can really add more value to applications (imagine Terminal using such features). |
I had the same question about NavigationView and this control. Just as an FYI, one decision that caused a lot of complexity with the NavigationView is that the Top and Left behaviors being different (scrolling vs overflow popout) |
It might be worth unifying TabView and NavigationView into a single control. They're both very similar and would benefit from each other's features. |
I think this would make a monster of a control. There is scope to just add a TabPosition property with Top, Bottom, Left, Right properties - and let the control handle the visuals for the tabs themselves. |
Edge also supports tab grouping, so the only feature missing from NavigationView would be the overflow flyout, apart from the design. Many other tab apps would also benefit from grouping. The tabs themselves could be separated into their own controls, kinda like with AppBarButton and CommandBar, if someone only needs those. Edit: microsoft/terminal#8267 |
TabView and NavigationView are two different patterns for apps, and TabView doesn't always have to be a top level UI (even if the current control is designed primarily for top level use) Merging the two controls would make it bloated and heavy, with too many options. They should remain separate IMO. |
An option could be to have a tabs container control, that only supports dragging and a horizontal/vertical mode. Then a control like NavigationView could use multiple such containers, for hierarchy, popups and footer items. The code could actually get smaller than it is today. |
3 years later... I vote for updating TabView and to not bloat NavigationView. This is nothing to do with the fact that I love Windows Terminal and want it to benefit from a vertical tab set since I also love vertical tabs in Edge. We hates horizontal tabs now. We hates them! ;) |
What can we, as users, do to make this a thing? |
Hopefully as people return from vacation, the old cruft is removed from the repo, and internal issues move to the GitHub - it may encourage Microsoft to get back on track with handling things. |
@mdtauk Unless I'm mistaken, the proposed cleanup strategy will not expose issues that are triaged internally. The plan was merely to trim outdated items from the GitHub issues list before teams track a copy of those internally. I'm almost positive that this wasn't a bi-directional commitment. |
Proposal: Vertical TabView
Summary
Edge will support vertical tabs in the next few months: https://blogs.windows.com/windowsexperience/2020/03/30/the-top-10-reasons-to-switch-to-the-new-microsoft-edge/
This proposal suggests adding a vertical mode to TabView.
Rationale
Scope
Important Notes
Open Questions
The text was updated successfully, but these errors were encountered: