Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PasswordBox: Password reveal button is not shown any longer when re-entering the control #3252

Closed
Felix-Dev opened this issue Sep 6, 2020 · 7 comments

Comments

@Felix-Dev
Copy link
Contributor

Describe the bug
By default the PasswordBox shows a password reveal button when the PasswordBox has focus and some content. However, when stepping out of the PasswordBox and then back into it, the password reveal button is no longer shown. Instead, the user will first have to clear the PasswordBox and then start typing again for the reveal button to show up.

Steps to reproduce the bug

  1. Open the XAML Controls Gallery app and go to the PasswordBox page.
  2. Start typing into a PasswordBox so that the reveal button is shown
  3. Set focus on another UI element, then re-enter the PasswordBox

Observe that the reveal button is no longer shown even though the PasswordBox has both focus and content.

Expected behavior
The password reveal button should be shown when re-entering a PasswordBox with content.

Screenshots
image
(A focused PasswordBox with focus and content, yet no password reveal button.)

Version Info

Windows app type:

UWP Win32
Windows 10 version Saw the problem?
Insider Build (xxxxx)
May 2020 Update (19041) Yes
November 2019 Update (18363)
May 2019 Update (18362)
October 2018 Update (17763)
April 2018 Update (17134)
Fall Creators Update (16299)
Creators Update (15063)
Device form factor Saw the problem?
Desktop Yes
Xbox
Surface Hub
IoT
@msft-github-bot msft-github-bot added the needs-triage Issue needs to be triaged by the area owners label Sep 6, 2020
@marcelwgn
Copy link
Contributor

This is by design. See #1224 where I also raised that concern.

@msft-github-bot msft-github-bot removed the needs-triage Issue needs to be triaged by the area owners label Sep 6, 2020
@Felix-Dev Felix-Dev reopened this Sep 6, 2020
@msft-github-bot msft-github-bot added the needs-triage Issue needs to be triaged by the area owners label Sep 6, 2020
@Felix-Dev
Copy link
Contributor Author

Felix-Dev commented Sep 6, 2020

Re-opening this issue as we might want to take a look at the documentation here to see if we can improve it (so meant as tracking the documentation issue). Just so we will avoid repeated mentions of this behavior as a bug in the future.

The documentation does state this information:
The password reveal button is shown only when the PasswordBox receives focus for the first time and a character is entered. If the PasswordBox loses focus and then regains focus, the reveal button is not shown again unless the password is cleared and character entry starts over.

It's listed in the documentation for the PasswordRevealMode API but not on the PasswordBox documentation main page first mentioning the reveal button. Should we surface that information on the main page as well?

@YuliKl FYI.

@marcelwgn
Copy link
Contributor

I think it makes sense to also mention this on the main page, not everyone will read the API documentation if they want to use the PasswordBox, especially since the API is not too surprising (in my opinion).

@YuliKl
Copy link

YuliKl commented Sep 8, 2020

The behavior is documented here but I agree would also be useful on the main API page. Can someone open a doc bug (by providing feedback for this page) on the main API page?

image

@Felix-Dev
Copy link
Contributor Author

@YuliKl I would just open a PR with the updated documentation instead (and link it here). Will get the change faster into this docs based on previous experiences :)

@YuliKl
Copy link

YuliKl commented Sep 8, 2020

Thank you, our docs team loves user contributions!

@Felix-Dev
Copy link
Contributor Author

Felix-Dev commented Sep 8, 2020

@YuliKl Created PR MicrosoftDocs/winrt-api#1811.

Closing this issue now as a documentation update has been approved (specific PR is now an issue for the docs repo).

Edit: PR has been merged.

@msft-github-bot msft-github-bot removed the needs-triage Issue needs to be triaged by the area owners label Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants