Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CalendarView: Tooltip is not provided for "Next" and "Previous" month buttons. #3525

Closed
YuliKl opened this issue Oct 30, 2020 · 4 comments
Closed
Labels
A11yLowImpact A11ySev3 A11yTest_CT A11yWCAG accessibility Narrator, keyboarding, UIA, etc area-DateTimePickers DatePicker, TimePicker, CalendarDatePicker, CalendarView help wanted Issue ideal for external contributors no-issue-activity team-Controls Issue for the Controls team

Comments

@YuliKl
Copy link

YuliKl commented Oct 30, 2020

Describe the bug

Steps to reproduce the bug

Steps to reproduce the behavior:

  1. Open Xaml Controls Gallery and navigation to CalendarView page
  2. Navigate to Previous, Next buttons
  3. Observe the issue.

Expected behavior

Tooltip should be provided for "Next" and "Previous" month buttons.

Screenshots

image

Additional context

Copied from internal bug

@YuliKl YuliKl added accessibility Narrator, keyboarding, UIA, etc area-DateTimePickers DatePicker, TimePicker, CalendarDatePicker, CalendarView needs-winui-3 Indicates that feature can only be done in WinUI 3.0 or beyond. (needs winui 3) A11yMAS labels Oct 30, 2020
@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Oct 30, 2020
@mdtauk
Copy link
Contributor

mdtauk commented Oct 30, 2020

As you have access to the month names, should they not be in the tooltip/accessibility name?

                        (Previous: February)     (Next: April)
March                           🔺                    🔻

@StephenLPeters StephenLPeters added team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners needs-winui-3 Indicates that feature can only be done in WinUI 3.0 or beyond. (needs winui 3) labels Oct 30, 2020
@StephenLPeters
Copy link
Contributor

I think that would be awesome, but probably requires winui 3. we can get static labels in winui2

@StephenLPeters StephenLPeters added the help wanted Issue ideal for external contributors label Oct 30, 2020
@Felix-Dev
Copy link
Contributor

Felix-Dev commented Nov 1, 2020

Binding the button tooltip content to the UIA name property of the respective button will give us "Previous" and "Next" as tooltips. Seems fine for now and we can add the month name once WinUI 3 has been open-sourced (for which we should create a new tracking item/proposal).

I would like to work on this.

@StephenLPeters @YuliKl How about adding a tooltip for the CalendarView's "header" button as well?
calendarview

Perhaps "Month view"/"Year view" (depending on how interpreted "Year view"/"Decade view" could also be used). This would require winui 3 though and the UIA name property of that button also isn't set. This wasn't flagged as an accessibility issue yet, but it's not looking unreasonable to me.

@github-actions
Copy link

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A11yLowImpact A11ySev3 A11yTest_CT A11yWCAG accessibility Narrator, keyboarding, UIA, etc area-DateTimePickers DatePicker, TimePicker, CalendarDatePicker, CalendarView help wanted Issue ideal for external contributors no-issue-activity team-Controls Issue for the Controls team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants