Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Preview 4] Change in Appearance of AppBarButton with Flyout on CommandBar in WinUI3 #4197

Closed
eleanorleffler opened this issue Feb 15, 2021 · 2 comments
Labels
area-Commanding AppBar, UICommand, MVVM, etc product-winui3 WinUI 3 issues team-Controls Issue for the Controls team

Comments

@eleanorleffler
Copy link

Describe the bug

We used a CommandBar with AppBarButton with a Flyout in our UWP application. However, once we switched over to WinUI3 Preview 4 Desktop, the appearance of the button changed.

The button in the WinUI3 Preview4 application has a ">" next to the icon whereas the UWP application did not.

See Screenshots below to compare differences.

Steps to reproduce the bug

  1. Clone the WinUI3 Problems CommandBarFlyout repository.
  2. Go to the CommandBarFlyoutWinUIPreview4 folder.
  3. Open the CommandBarFlyoutWinUIPreview4 solution in Visual Studio 2019 Preview.
  4. Build and run with Debug x64.
  5. Notice the additional ">" next to the first icon in the CommandBar on the right side of the application.

Expected behavior

We expect to see no difference in appearance in the UWP and WinUI3 Preview 4 Desktop CommandBar buttons. The button in the WinUI3 Preview 4 Desktop application should only be the AppBarButton icon.

Build and run the CommandBarFlyoutUWP inside the CommandBarFlyoutUWP folder to see expected behavior.

Screenshots

ExpectedBehavior

Screenshot#1 - Expected Appearance (UWP)

CurrentBehavior

Screenshot#2 - Current Appearance (WinUI3 Desktop)

Version Info

NuGet package version:

[Microsoft.WinUI 3.0.0-preview4.210210.4]

Targeting:
Target: Universal Windows
Target version: Windows 10, version 1809 (10.0; Build 17763)
Min version: Windows 10, version 1803 (10.0; Build 17134)

Windows app type:

UWP Win32
Yes
Windows 10 version Saw the problem?
Insider Build (xxxxx)
May 2020 Update (19041)
November 2019 Update (18363)
May 2019 Update (18362)
October 2018 Update (17763) Yes
April 2018 Update (17134)
Fall Creators Update (16299)
Creators Update (15063)
Device form factor Saw the problem?
Desktop Yes
Xbox
Surface Hub
IoT

Additional context

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Feb 15, 2021
@StephenLPeters StephenLPeters added area-Commanding AppBar, UICommand, MVVM, etc team-Controls Issue for the Controls team product-winui3 WinUI 3 issues labels Feb 17, 2021
@StephenLPeters
Copy link
Contributor

In winui2 there is a bug where this chevron appears for app bar buttons which have attached flyouts, but only when they are not in command bar's primary commands. It seems like this issue is that command bar is failing to apply its custom style to this app bar button.

@anawishnoff
Copy link
Contributor

This bug has been fixed in WinUI 3 in the upcoming Project Reunion 0.8 Preview, which you can expect within the next few days. Thanks for filing this!

@anawishnoff anawishnoff added the fixed-internally This bug has been fixed, and the fix will be shipped in the next version of WinUI 3. label May 6, 2021
@bpulliam bpulliam removed the fixed-internally This bug has been fixed, and the fix will be shipped in the next version of WinUI 3. label Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Commanding AppBar, UICommand, MVVM, etc product-winui3 WinUI 3 issues team-Controls Issue for the Controls team
Projects
None yet
Development

No branches or pull requests

4 participants