Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Update design of DatePicker and TimePicker controls #4308

Open
anawishnoff opened this issue Feb 23, 2021 · 6 comments
Open

Proposal: Update design of DatePicker and TimePicker controls #4308

anawishnoff opened this issue Feb 23, 2021 · 6 comments
Labels
area-DateTimePickers DatePicker, TimePicker, CalendarDatePicker, CalendarView area-UIDesign UI Design, styling feature proposal New feature proposal team-Controls Issue for the Controls team

Comments

@anawishnoff
Copy link
Contributor

anawishnoff commented Feb 23, 2021

Proposal: Update design of DatePicker and TimePicker controls

Summary

I'm proposing design changes to the DatePicker and TimePicker controls. These changes are mostly based around rounding the visuals seen in Date/TimePicker, in both rest and non-rest states. Some work has already been done to update the colors and shapes within Date/TimePicker, but this proposes work that will finish the job and align the design of this control with the new designs proposed for ListView.

Rationale

  • Many controls in WinUI have rounded corners, so Date/TimePicker items should follow that trend and embrace the modern, Fluent look.

Scope

Capability Priority
The horizontal "selection bar" in Date/TimePicker should have rounded corners, and sufficient padding from the edge of the control. Must
Hovered items should have a grey rounded backplate, similar to the proposed hover state for ListView items. Must
When any of the action glyphs are hovered (check, x, scroll buttons) they should have a rounded grey backplate, similar to list items. Must
Date/TimePicker should have smooth entrance and exit animations that match those of other updated controls such as CommandBarFlyout and MenuFlyout. Must
These changes will not affect the functionality of Date/TimePicker. Won't

Important Notes

Design Mockups

Below: Old and new versions of DatePicker.
image

Below: Old and new versions of TimePicker.
image

Below: A close-up showing the rounded backplate on the buttons.
image

@anawishnoff anawishnoff added the feature proposal New feature proposal label Feb 23, 2021
@ghost ghost added this to Freezer in Feature tracking Feb 23, 2021
@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Feb 23, 2021
@mdtauk
Copy link
Contributor

mdtauk commented Feb 23, 2021

Will the 40px highlighted size change to 32px to match the height of the picker before the flyout renders?

@anawishnoff
Copy link
Contributor Author

@mdtauk Yes, the selection rectangle would have a height of 32px.

@ranjeshj ranjeshj added area-UIDesign UI Design, styling area-DateTimePickers DatePicker, TimePicker, CalendarDatePicker, CalendarView team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Feb 24, 2021
@mdtauk
Copy link
Contributor

mdtauk commented Feb 24, 2021

Will it also be possible to improve the entrance and exit animation of the Flyouts for Date and Time Picker? The MenuFlyout and the CommandBarFlyout have nice smooth flowing animations, but Date and Time Picker just appears on screen.

Back in the Windows 8 days, these controls animated up and down from the Button/Form control you click on to show the flyout.

@nc-x
Copy link

nc-x commented Feb 24, 2021


My laptop (unfortunately) does not have a nice display, because of which the backplate / highlight is pretty much invisible to me. Same issue in #4304 and #4305. They need better contrast, otherwise the applications using WinUI will be unusable for a lot of people.

@anawishnoff
Copy link
Contributor Author

@nc-x Thanks for pointing that out - I'll look into this!

@mdtauk Another great point. I agree that Date/TimePicker should match the nice entrance and exit animations of other more updated controls. I'm going to add that to my proposal above - thanks!

@jordan-msftfan
Copy link

jordan-msftfan commented Apr 17, 2021

Is this proposal has already been done on #4460?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-DateTimePickers DatePicker, TimePicker, CalendarDatePicker, CalendarView area-UIDesign UI Design, styling feature proposal New feature proposal team-Controls Issue for the Controls team
Projects
Visual update
Awaiting triage
Development

No branches or pull requests

5 participants