Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ItemsRepeater within ListView causing layout cycles #544

Closed
joshkoon opened this issue Apr 10, 2019 · 2 comments
Closed

ItemsRepeater within ListView causing layout cycles #544

joshkoon opened this issue Apr 10, 2019 · 2 comments
Assignees
Labels
area-ItemsRepeater area-Lists ListView, GridView, ListBox, etc team-Controls Issue for the Controls team
Milestone

Comments

@joshkoon
Copy link
Member

Describe the bug
"Layout cycle detected" exception when using ItemsRepeater inside a ListView

Steps to reproduce the bug
Steps to reproduce the behavior:

  1. Create an app which uses a ListView, e.g. https://github.com/Microsoft/Windows-universal-samples/tree/master/Samples/XamlBottomUpList, using the Incremental Loading example
  2. Add an ItemsRepeater control to the data template for the ListViewItems and bind the ItemsSource to a value.
  3. Run the app. As enough items are added to require scrolling the list, the layout cycle exception fires.

Expected behavior
XAML should handle this scenario without crashing

Screenshots
image

Version Info

NuGet package version:
Microsoft.UI.Xaml 2.1.190405004

Windows 10 version Saw the problem?
Insider Build (18xxx, Latest) Yes
October 2018 Update (17763)
April 2018 Update (17134)
Fall Creators Update (16299)
Creators Update (15063)
Anniversary Update (14393)
Device form factor Saw the problem?
Desktop Yes
Mobile
Xbox
Surface Hub
IoT

Additional context

@msft-github-bot msft-github-bot added this to Needs triage in Controls Triage Apr 10, 2019
@micahl micahl added area-ItemsRepeater area-Lists ListView, GridView, ListBox, etc labels Apr 10, 2019
@jevansaks jevansaks moved this from Needs triage to Approved in Controls Triage Apr 12, 2019
@msft-github-bot msft-github-bot moved this from Approved to Approved - Assigned in Controls Triage Apr 12, 2019
@micahl
Copy link
Contributor

micahl commented Apr 15, 2019

This issue should be fixed by #557

@jevansaks jevansaks moved this from Approved - Assigned to Approved in Controls Triage May 7, 2019
@micahl micahl added this to the WinUI 2.2 milestone May 8, 2019
@jevansaks
Copy link
Member

Per @micahl's comment, I"m going to close this. Please let us know if you still see it?

Controls Triage automation moved this from Backlog to Closed Jul 12, 2019
@jevansaks jevansaks added the team-Controls Issue for the Controls team label Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-ItemsRepeater area-Lists ListView, GridView, ListBox, etc team-Controls Issue for the Controls team
Projects
No open projects
Development

No branches or pull requests

4 participants