Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pivot control becomes a focus trap when a keyboard accelerator causes a child listview to be cleared #648

Closed
danbelcher-MSFT opened this issue May 3, 2019 · 1 comment
Labels
area-FocusManager Focus APIs such as Control.Focus(), FocusManager.Try[Move]Focus[Async], keyboarding with [shift+]tab needs-winui-3 Indicates that feature can only be done in WinUI 3.0 or beyond. (needs winui 3) no-issue-activity team-Reach Issue for the Reach team

Comments

@danbelcher-MSFT
Copy link

Describe the bug
This bug is very specific. Given a PivotItem containing a ListView with items and a Button that clears the list, the Pivot becomes a focus trap if the Button has focus and is invoked by keyboard accelerator.
Visual tree shows focus is stuck on the Pivot's HeaderClipper element.

Steps to reproduce the bug
Sample app is available here: https://github.com/danbelcher-MSFT/PivotFocusTrapRepro
The specific changes I made for this to repro can be found in this commit: danbelcher-MSFT/PivotFocusTrapRepro@621fa71

To repro, add a few items to the list, navigate to the Delete button, and press Ctrl+L to invoke. Navigate to the Pivot header and observe that focus is trapped.

The bug only seems to repro if the button is invoked by keyboard accelerator. If invoked with mouse/space, the bug does not repro.

Expected behavior
Pivot should not become a focus trap. Behavior should not be different if the Button is invoked with keyboard accelerator vs other methods.

Version Info

Bug repros in XAML framework.

NuGet package version:
Bug also repros in Windows Calculator's History/Memory list.
[Microsoft.UI.Xaml 2.1.190405004.2]

Windows 10 version Saw the problem?
Insider Build (xxxxx) 18890.rs_apps.190427
Device form factor Saw the problem?
Desktop Yes
@msft-github-bot msft-github-bot added this to Needs triage in Controls Triage May 3, 2019
@jevansaks jevansaks added this to Needs triage in Reach Triage via automation May 7, 2019
@jevansaks jevansaks removed this from Needs triage in Controls Triage May 7, 2019
@Austin-Lamb Austin-Lamb added the area-FocusManager Focus APIs such as Control.Focus(), FocusManager.Try[Move]Focus[Async], keyboarding with [shift+]tab label May 7, 2019
@Austin-Lamb Austin-Lamb self-assigned this May 7, 2019
@Austin-Lamb Austin-Lamb moved this from Needs triage to Investigate / needs follow-up in Reach Triage May 7, 2019
@msft-github-bot msft-github-bot added the needs-assignee-attention Assignee needs to follow-up or investigate this issue label May 7, 2019
@Austin-Lamb Austin-Lamb moved this from Investigate / needs follow-up to Backlog in Reach Triage Jun 7, 2019
@msft-github-bot msft-github-bot removed the needs-assignee-attention Assignee needs to follow-up or investigate this issue label Jun 7, 2019
@Austin-Lamb Austin-Lamb added the needs-winui-3 Indicates that feature can only be done in WinUI 3.0 or beyond. (needs winui 3) label Aug 26, 2019
@Austin-Lamb Austin-Lamb removed their assignment Nov 6, 2019
@jevansaks jevansaks added the team-Reach Issue for the Reach team label Nov 7, 2019
@github-actions
Copy link

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-FocusManager Focus APIs such as Control.Focus(), FocusManager.Try[Move]Focus[Async], keyboarding with [shift+]tab needs-winui-3 Indicates that feature can only be done in WinUI 3.0 or beyond. (needs winui 3) no-issue-activity team-Reach Issue for the Reach team
Projects
No open projects
Development

No branches or pull requests

4 participants