Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ToggleSplitButton] Inconsistent Disabled colors and poor contrast #6500

Closed
2 tasks done
niels9001 opened this issue Dec 19, 2021 · 8 comments
Closed
2 tasks done

[ToggleSplitButton] Inconsistent Disabled colors and poor contrast #6500

niels9001 opened this issue Dec 19, 2021 · 8 comments
Labels
area-Accessibility area-ToggleSwitch area-UIDesign UI Design, styling bug Something isn't working team-Controls Issue for the Controls team

Comments

@niels9001
Copy link
Contributor

Describe the bug

When is ToggleSplitButton is IsChecked and disabled, the Content gets very hard to read. (See screenshots below). It's also incosistent when comapring it to the a disabled Button (with AccentButtonStyle) or disabled ToggleButton.

Steps to reproduce the bug

Add

<Grid> <muxc:ToggleSplitButton IsEnabled="False" IsChecked="True" Margin="12" Content="ToggleSplitButton with checked state and disabled" /> <Button Style="{ThemeResource AccentButtonStyle}" Content="Button with AccentButtonStyle and disabled" IsEnabled="False" Margin="12" /> <ToggleButton IsChecked="True" Content="ToggleButton and disabled" IsEnabled="False" Margin="12" /> </Grid>

Expected behavior

  • Better contrast meeting accessibility requirements
  • Similar visual to AccentButtonStyle and ToggleButton

Screenshots

Light theme

image

Dark theme

image

NuGet package version

No response

Windows app type

  • UWP
  • Win32

Device form factor

Desktop

Windows version

No response

Additional context

No response

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Dec 19, 2021
@robloo
Copy link
Contributor

robloo commented Dec 20, 2021

Related to #6469

@robloo
Copy link
Contributor

robloo commented Dec 20, 2021

This one is easier to fix and should just require inverting the colors in the resource brushes.

@StephenLPeters StephenLPeters added area-ToggleSwitch team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Mar 1, 2022
@StephenLPeters
Copy link
Contributor

@chigy FYI, can you suggest the proper behavior?

@StephenLPeters StephenLPeters added the area-UIDesign UI Design, styling label Mar 1, 2022
@Jay-o-Way
Copy link
Contributor

This one is easier to fix and should just require inverting the colors in the resource brushes.

So, what's keeping this back? :) @robloo

@robloo
Copy link
Contributor

robloo commented Feb 2, 2023

  1. Microsoft design team has to decide things like this. They never replied.
  2. I've moved away from WinUI so won't be looking at this.

@crutkas
Copy link
Member

crutkas commented Jul 8, 2023

@chigy is this something being Looked at

@niels9001
Copy link
Contributor Author

@chigy is this something being Looked at

WinUI does not have Accent button styles beyond the default button. So this is a custom style we've created.

@duncanmacmichael duncanmacmichael added the bug Something isn't working label Oct 31, 2023
@DmitriyKomin
Copy link
Contributor

@niels9001, thank you for reporting this. Trying the repro XAML on WinAppSDK 1.5 / Windows 11, readability appears better than the previous (blue) screenshot:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Accessibility area-ToggleSwitch area-UIDesign UI Design, styling bug Something isn't working team-Controls Issue for the Controls team
Projects
None yet
Development

No branches or pull requests

8 participants