Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MenuFlyout and CommandBarFlyout have different opening animation #6869

Closed
1 of 2 tasks
roxk opened this issue Mar 22, 2022 · 8 comments
Closed
1 of 2 tasks

MenuFlyout and CommandBarFlyout have different opening animation #6869

roxk opened this issue Mar 22, 2022 · 8 comments
Labels
area-CommandBarFlyout area-Menus bug Something isn't working needs-triage Issue needs to be triaged by the area owners team-Controls Issue for the Controls team

Comments

@roxk
Copy link

roxk commented Mar 22, 2022

Describe the bug

A menu flyout opens by sliding in, whereas a command bar flyout opens by fading in.

Steps to reproduce the bug

  1. Create MenuFlyout and CommandBarFlyout
  2. Open them.
  3. Observe different opening animation

Expected behavior

The animation should be the same?
Also, it seems the command bar flyout isn't aligned to the mouse cursor, whereas menu flyout is aligning perfectly.

It' be great if WinUI's figma can specify these kinds of animation as well.

Screenshots

2022-03-22_11-38-27.mp4

NuGet package version

Microsoft.UI.Xaml 2.7.0

Windows app type

  • UWP
  • Win32

Device form factor

Desktop

Windows version

Windows 11 (21H2): Build 22000

Additional context

No response

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Mar 22, 2022
@ojhad ojhad added area-Menus team-Controls Issue for the Controls team area-CommandBarFlyout and removed needs-triage Issue needs to be triaged by the area owners labels Mar 23, 2022
@github-actions
Copy link

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@duncanmacmichael duncanmacmichael added the bug Something isn't working label Oct 31, 2023
@DmitriyKomin
Copy link
Contributor

@roxk, thank you for reporting this. The animations are different by design, there are no plans to make changes here.

@DmitriyKomin DmitriyKomin closed this as not planned Won't fix, can't repro, duplicate, stale Mar 1, 2024
@yaira2
Copy link
Contributor

yaira2 commented Mar 1, 2024

@DmitriyKomin can you please explain the rationale for this design choice? Depending on the item that's right clicked, we'll sometimes display a MenuFlyout and other times a CommandBarFlyout.

Having different animations appears to our users as a bug so it'll help if this issue is resolved or if there is an official explanation we can pass on to users.

@RichardLuo0
Copy link

Plz change this. I always feel the fade-in animation is very awkward

@codendone
Copy link
Contributor

As the names of these flyout types may imply, their origins are in supporting different control contexts with different expected usage patterns. Each animation was chosen for that specific context. Using them directly side by side wasn't part of that design. While I can see the experience being a bit jarring in the way shown here, changing the animations would have other repercussions and likely require added customization that just isn't a priority at this moment relative to the severity.

@codendone codendone removed the needs-triage Issue needs to be triaged by the area owners label Jun 27, 2024
@yaira2
Copy link
Contributor

yaira2 commented Jul 2, 2024

Animations can significantly impact the user experience, so this response is disappointing to me. I understand that the controls are independent, but there should still be consistency between them. While I agree that there are higher priority items, it would be beneficial for the community to keep this issue open for tracking.

It’s also worth noting that File Explorer uses them side by side, similar to how we do in Files. Given this, along with user feedback, it seems to me that it's necessary to reconsider this approach.

@microsoft-github-policy-service microsoft-github-policy-service bot added the needs-triage Issue needs to be triaged by the area owners label Jul 2, 2024
@0x5bfa
Copy link

0x5bfa commented Jul 2, 2024

Every flyout (Flyout, MenuFlyout, CommandBarFlyout) has each different transition. When you want to put some custom controls you have to use Flyout but sometimes you'd like to keep consisntency. Also, we don't expect different transition to the similar control types for different usecase (left click or right click).

image

@p3rid0t
Copy link

p3rid0t commented Jul 2, 2024

I think this issue should be reopened and reconsidered, even if just to provide a space for discussion.

The CommandBarFlyout animation feels sluggish. It takes too long to open, and often suffers from stuttering or disappearing altogether. Plus it adds even more unnecessary inconsistencies into the Windows UI ecosystem...

My two cents: I'd consider replacing the custom fade animation with the Flyout animation. Why?
The MenuFlyout animation wouldn't fit as it would be too fast (and CommandBarFlyouts are usually bigger than MenuFlyouts)
Meanwhile, normal Flyouts have a smoother animation that is more appropriate and optimized for larger surfaces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-CommandBarFlyout area-Menus bug Something isn't working needs-triage Issue needs to be triaged by the area owners team-Controls Issue for the Controls team
Projects
None yet
Development

No branches or pull requests

9 participants