Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create CSS-inspired GridLayout for preview #696

Closed
20 of 22 tasks
chrisglein opened this issue May 13, 2019 · 9 comments
Closed
20 of 22 tasks

Create CSS-inspired GridLayout for preview #696

chrisglein opened this issue May 13, 2019 · 9 comments
Assignees
Labels

Comments

@chrisglein
Copy link
Member

chrisglein commented May 13, 2019

Tracking feature for prototyping an implementation of CSS-inspired Grid layout and putting into preview for community feedback.

Modeled after this feature request #54

  • Prototype panel based layout
  • Move to Repeater/LayoutPanel layout
  • Index grid location
  • LineName grid location
  • Span grid location offset
  • Pixel-based grid track
  • Fraction-based grid track
  • Percentage-based grid track
  • Auto grid track
  • Name grid lines
  • Ability to name last line that doesn't map to a track
  • ColumnStart/RowStart
  • ColumnEnd/RowEnd
  • TemplateColumns/TemplateRows
  • ColumnGap/RowGap
  • JustifyItems/AlignItems
  • JustifyContent/AlignContent
  • AutoColumns/AutoRows
  • AutoFlow
  • JustifySelf/AlignSelf
  • Create demo pages
  • Create tests
@chrisglein chrisglein self-assigned this May 13, 2019
@brianlagunas
Copy link

Please do not fragment WinUI by adding CSS to it. There's a reason WinJS was rejected by the masses and died.

@mdtauk
Copy link
Contributor

mdtauk commented May 14, 2019

Please do not fragment WinUI by adding CSS to it. There's a reason WinJS was rejected by the masses and died.

It's not adding CSS, but making a new Grid Control which has all the functionality of the CSS version. Think of it as an enhanced and modernised Grid

@JustinXinLiu
Copy link

So much this. The web has evolved with a lot of cool layout attributes. It's time for the XAML layout system to learn from them.

@jevansaks jevansaks added this to Needs triage in Controls Triage via automation May 14, 2019
@jevansaks jevansaks moved this from Needs triage to Approved in Controls Triage May 14, 2019
@chrisglein
Copy link
Member Author

Please do not fragment WinUI by adding CSS to it. There's a reason WinJS was rejected by the masses and died.

This work has nothing to do with CSS, but with the grid layout available via CSS (display: grid). I only put CSS grid in the title to disambiguate from the existing XAML Grid layout panel (anyone know a better name for CSS grid?). I highly recommend you give CSS grid a look, it's frankly great! I've been using it for a few months now and am genuinely impressed by how it helps me in a lot of common scenarios.

@brianlagunas
Copy link

@chrisglein I know the CSS grid quite well, but I am 100% against adding any type of CSS syntax requirement to the WinUI/XAML platforms. Learn from the CSS Grid features/functionality, but don't take on new language requirements.

@chrisglein
Copy link
Member Author

@chrisglein I know the CSS grid quite well, but I am 100% against adding any type of CSS syntax requirement to the WinUI/XAML platforms. Learn from the CSS Grid features/functionality, but don't take on new language requirements.

Again, this work has nothing to do with CSS syntax. Have you looked at @micahl's proposal that I linked above?

@brianlagunas
Copy link

@chrisglein Yes. What scared me was your comment that had CSS embedded in a style (#54 (comment)) but after reading it more closely, it looks like you were just using it as a comparison and not the actual syntax that would be used.

False alarm.... carry on 😄

@marcelwgn
Copy link
Contributor

Just out of curiosity, what happened to this proposal? The CSS grid layout is very powerful and I would love to be able to have something like that in XAML.

@github-actions
Copy link

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

No branches or pull requests

6 participants