Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create CODEOWNERS so that Pull Requests can have default assigned Reviewers #71

Closed
chrisglein opened this issue Dec 12, 2018 · 0 comments
Closed

Create CODEOWNERS so that Pull Requests can have default assigned Reviewers #71

chrisglein opened this issue Dec 12, 2018 · 0 comments
Assignees
@jevansaks
Labels
documentation An issue with existing documentation or a request for documenation of a new topic team-Controls Issue for the Controls team

Comments

@chrisglein
Copy link
Member

Describe the bug
Currently new Pull Requests open up with no Reviewers assigned. One way to address that is by creating a CODEOWNERS as described here. If that's more specific than just the code review group then it could provide a helpful place to @ mention area owners.

Note that only an admin or owner can add a CODEOWNERS file.

Steps to reproduce the bug

  1. Create a new pull request

Expected behavior
Reviewers is unassigned (should have microsoft-ui-xaml-codereviews)
@chrisglein chrisglein added the documentation An issue with existing documentation or a request for documenation of a new topic label Dec 12, 2018
@jevansaks jevansaks added the team-Controls Issue for the Controls team label Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jevansaks jevansaks

Labels
documentation An issue with existing documentation or a request for documenation of a new topic team-Controls Issue for the Controls team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jevansaks @chrisglein