New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When hiding titlebar a few white pixels still show on top #8947
Comments
@mevey can you take a look? cc: @btueffers |
pong @rkarman |
I've successfully repro-ed this bug :( and filed it task.ms/40617153 |
Hi @dotMorten, what is the intended goal of hiding the title bar? To draw your own? To have a PIP experience? To have a window that is not movable or resizable perhaps? This is helpful as we try to figure out how to solve this problem. |
@mevey I'd ask the Windows App SDK team who added that API :-) |
Perhaps @ArchieCoder can add details, since he originally logged this bug in WinUIEx |
Here is my original issue in WinUIEx: dotMorten/WinUIEx#67 Someone has the workaround: dotMorten/WinUIEx#67 (comment) |
@ArchieCoder thanks but I think they are looking for the ‘why’ you were doing this to justify fixing their API |
The original goal was to hide the color of the title bar because it didn't find the rest of the app. If the title bar color can be changed, this is then a non-issue anymore. |
It seems unchanged in WAS 1.3, so should I consider it a normal behavior? At least, 'ExtendsContentIntoTitleBar' helps eliminate the white space. |
we would like to get rid of this little white border as well. we want to have full control over the appearance of the window for our app and this prevents us from doing that |
@stevenbrix That's the caption area peeking out there; here's a workaround for now:
Notes:
|
I am aware of this issue. Seems like something Windows shell puts and unless it gets patched, it cannot be removed. I suggest not using this api (if rest of appwindow/winui3 custom titlebar apis are not filling the requirements, because they cover a lot cases now including interactive controls within the titlebar), but rolling out a custom titlebar solution using a custom WndProc and using WS_EX_LAYERED and WS_OVERLAPPED styles, but using 1.4 newly introduced |
@pratikone Are you saying |
@pratikone @tiberiu2 Can either of you answer my question? I was simply asking for clarification of @pratikone's comment above. Thanks! |
I am not saying that at all. I am saying that while this issue gets fixed (given the fix has to be in windows shell code) , there exists a immediate workaround which is much simpler than earlier i.e. let InputNonClientPointerSource apis handle NC messages for a vanilla custom solution. |
Sounds like we're in disagreement over "forever", that's fair. Maybe we can get this documented as a known issue when using this API for future devs? |
Yeah, that seems right. This issue has existed for some time and affects any app which does custom titlebar. If you are quick enough, you can spot it during launch of Visual Studio too. It goes away quickly. Let me check internally if we can make some progress on fixing this.if not, getting it documented would be a good step too. Thanks for the suggestion |
Fixed in 1.4.3, closing issue. |
I just tested in ver 1.4.3 but issue still remains |
I see the same thing. @duncanmacmichael Can we're open this? |
Describe the bug
When hiding the titlebar using
OverlappedPresenter.SetBorderAndTitleBar(true, false)
a few pixels of white titlebar still shows.Steps to reproduce the bug
RequestedTheme="Dark"
Run the app, and observe the white color on top of the window.
Expected behavior
Entire window is black
Screenshots
NuGet package version
1.1.3
Packaging type
Packaged (MSIX)
Windows version
Windows 11 version 21H2 (22000)
IDE
Visual Studio 2022-preview
Additional context
First reported in WinUIEx: dotMorten/WinUIEx#67
The text was updated successfully, but these errors were encountered: