Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: TimePicker should be split into single digits again. #905

Open
shaheedmalik opened this issue Jun 20, 2019 · 14 comments
Open

Proposal: TimePicker should be split into single digits again. #905

shaheedmalik opened this issue Jun 20, 2019 · 14 comments
Assignees
Labels
area-DateTimePickers DatePicker, TimePicker, CalendarDatePicker, CalendarView feature proposal New feature proposal team-Controls Issue for the Controls team

Comments

@shaheedmalik
Copy link

shaheedmalik commented Jun 20, 2019

Proposal: [TimePicker should be split back into into single digits again.]

Summary

The TimePicker as currently designed takes way to long to select the wanted time using touch, keyboard, and mouse devices

Rationale

  • {It is time consuming to select the wanted minutes to times in apps the use the time control}
  • {If I want to select 35 minutes for example, I will have to either stroll 35 times or 25 times to select that number, versus with separate controls, I will scroll only 7 times or 9 times}
  • {etc}

Scope

Capability Priority
Make it easier to keyboard, mouse and tablet users to select the number they want faster. Must
Look pretty. Should

Important Notes

Open Questions

@shaheedmalik shaheedmalik added the feature proposal New feature proposal label Jun 20, 2019
@msft-github-bot msft-github-bot added this to Freezer in Feature tracking Jun 20, 2019
@msft-github-bot msft-github-bot added this to Needs triage in Controls Triage Jun 20, 2019
@mdtauk
Copy link
Contributor

mdtauk commented Jun 20, 2019

I have to disagree about splitting the controls into single digits. But an editable Time Picker?

image

@shaheedmalik
Copy link
Author

I have to disagree about splitting the controls into single digits. But an editable Time Picker?

image

It may look nice on paper but it isn't functional.

@YuliKl YuliKl added the area-DateTimePickers DatePicker, TimePicker, CalendarDatePicker, CalendarView label Jun 20, 2019
@YuliKl YuliKl moved this from Needs triage to Backlog in Controls Triage Jun 20, 2019
@mdtauk
Copy link
Contributor

mdtauk commented Jun 20, 2019

I have to disagree about splitting the controls into single digits. But an editable Time Picker?
image

It may look nice on paper but it isn't functional.

image

Making it editable means you can type in the time, which is the easiest way to do it with Keyboard, and still able to press to bring up the picker controls for touch. Also there is a proposal for an Editable Date Picker too, so this would fit well with that.

The problem with breaking apart the two digit combos, comes with making the meaning clear for the reading of hours, minutes.
image

Adding seconds into the mix doesn't help matters.
image

@shaheedmalik
Copy link
Author

Typing the time doesn't help someone using a tablet.

@mdtauk
Copy link
Contributor

mdtauk commented Jun 21, 2019

If the proposal is accepted, I would not want it to become the default. I think it should be a property of the control. TimePicker.SplitDigits = true;

@dpierangeli
Copy link

I'm with @mdtauk . Yes, the split digits could help the tablet users (could because the only real tablet OS out there - iOS - uses the compact digit and no one has complained) but it can be a secondary and optional mode, to not trouble those apps that are geared to the desktop.

@kikisaints
Copy link

I had an internal proposal similar to this a while ago. It was basically a proposal to change TimePicker to three ComboBoxes "linked" together seamlessly. That meant that inherited properties like IsEditable would come along, but the base control would operate as you'd expect with keyboard, mouse and touch - because ComboBox works nicely with all three.

combobox_timepicker_vid

@mdtauk
Copy link
Contributor

mdtauk commented Jun 21, 2019

@kikisaints that's is an interesting approach. The chevrons do add some bulk, which could be massaged with a design similar to the ones I explored.

It doesn't quite address the issue in the proposal, as they wanted to avoid long scrolls for the minutes, by having the two digits of the minutes separate.

But like the proposal for an Editable Date Picker, an Editable Time Picker, would fill the control suite out nicely.

Does IsEditable become a property on the existing controls, or should they be new controls?


What was the conclusion of that internal proposal?

@kikisaints
Copy link

Ah I misunderstood the original proposal a bit. @shaheedmalik What scenario(s) were you thinking that having the 1s and 10s places' separate would solve? I'm curious if you have a particular need here besides ease of use/nice to have.

@mdtauk the proposal in general was agreed upon as an improvement, but we didn't have the dev resources to act on it, so it was moved "out" and has not been revisited since.
Also, I agree the chevrons are a bit unnecessary, but it's nothing a refreshed template couldn't fix/hide.

Additionally, depending on how the "new" timepicker inherited from ComboBox, it would be a property on the "new" control. Which in this proposal is just a re-skin of ComboBox. If that's what you meant?

@kmgallahan
Copy link
Contributor

I like the current design with loop-around scrolling and auto-selection based on the currently highlighted item. It is good for touch and mouse wheels with infinite scroll (where the wheel rotates freely without clicking). I understand though that if your mouse wheel requires a click for each digit change then it could be annoying.

Split digits for minutes/seconds adds extra input steps and clutters the UI. Combo boxes require both scrolling and selection, plus the chevrons are not attractive.

I agree with @mdtauk that accepting keyboard input would be the most helpful addition, and this would not take a step backwards from the current design - depending on what input method is being used.

The main design consideration for keyboard input would be how to indicate which part of the TimerPicker has focus, and how to change focus.

@mdtauk
Copy link
Contributor

mdtauk commented Jun 21, 2019

@kikisaints With it all going Open Source - that makes the proposal more likely to happen. WinUI 3.0's initial release is the priority for now, but don't abandon the idea.

image

@kikisaints
Copy link

@mdtauk 😄 Absolutely, just hadn't thought about it until this issue was posted. Although it's outside of the scope of what shaheedmalik is asking for, I did create a separate issue here: #918

@ccarlo88
Copy link

This already exist in the UWP:
image

@shaheedmalik
Copy link
Author

This already exist in the UWP:
image

What are you responding to? That wasn't the purpose of the proposal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-DateTimePickers DatePicker, TimePicker, CalendarDatePicker, CalendarView feature proposal New feature proposal team-Controls Issue for the Controls team
Projects
Development

No branches or pull requests

8 participants