Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MapControl has a blue background #9377

Open
dotMorten opened this issue Mar 1, 2024 · 5 comments
Open

MapControl has a blue background #9377

dotMorten opened this issue Mar 1, 2024 · 5 comments
Labels
bug Something isn't working fixed-internally This bug has been fixed, and the fix will be shipped in the next version of WinUI 3. team-Controls Issue for the Controls team
Milestone

Comments

@dotMorten
Copy link
Contributor

dotMorten commented Mar 1, 2024

Describe the bug

The default background of the mapcontrol is blue. This should be the background color of the MapControl.Background property instead.

Steps to reproduce the bug

Launch the mapcontrol. Before it loads the tiles, you'll see the "blue window of death".
Use Two-finger drag to "tilt" the map into 2.5D mode, and zoom out to the entire world. Notice the blue areas above and below
+

Expected behavior

Background matches the background of my control - at least if it's a solid color brush, you should be able to forward that color to html.

Screenshots

image

NuGet package version

1.5.240227000

Windows version

22H2 (22621.3085)

Additional context

Problem is caused by this line of code:

background-color: blue;

It looks like some early debugging code that was never cleaned up.

@dotMorten dotMorten added the bug Something isn't working label Mar 1, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the needs-triage Issue needs to be triaged by the area owners label Mar 1, 2024
@ranjeshj ranjeshj added team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Mar 1, 2024
@gegao18
Copy link

gegao18 commented Mar 5, 2024

Thanks for reporting and investigating this. We've checked in a fix for our first 1.5 servicing release.

@gegao18 gegao18 closed this as completed Mar 5, 2024
@codendone codendone added this to the WinAppSDK 1.5 milestone Mar 5, 2024
@codendone codendone added the fixed-internally This bug has been fixed, and the fix will be shipped in the next version of WinUI 3. label Mar 5, 2024
@riverar
Copy link
Contributor

riverar commented Mar 6, 2024

@gegao18 What was the change? Is it now wired to the control background?

@microsoft-github-policy-service microsoft-github-policy-service bot added the needs-triage Issue needs to be triaged by the area owners label Mar 6, 2024
@riverar
Copy link
Contributor

riverar commented Mar 26, 2024

@gegao18 Hello?

@gegao18
Copy link

gegao18 commented Mar 26, 2024

For 1.5.1 we just took out the blue background. The maps page now has a transparent background, which will show the default white of the WebView2. I'm reopening this to hook up the map background to the control background for the invalid and zoomed out states.

@gegao18 gegao18 reopened this Mar 26, 2024
@riverar
Copy link
Contributor

riverar commented Mar 27, 2024

@gegao18 Thanks for the follow up!

@codendone codendone removed the needs-triage Issue needs to be triaged by the area owners label Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed-internally This bug has been fixed, and the fix will be shipped in the next version of WinUI 3. team-Controls Issue for the Controls team
Projects
None yet
Development

No branches or pull requests

5 participants