Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression the position of one of images in MenuFlyoutItem is incorrect #9409

Open
0x5bfa opened this issue Mar 7, 2024 · 7 comments
Open
Labels
area-Menus bug Something isn't working Regression team-Controls Issue for the Controls team

Comments

@0x5bfa
Copy link

0x5bfa commented Mar 7, 2024

Describe the bug

image

Steps to reproduce the bug

  1. Add flyout item more than 2
  2. See the icon position is wrong

Expected behavior

The same position as before.

Screenshots

No response

NuGet package version

None

Windows version

Windows 11 (22H2): Build 22621

Additional context

No response

@0x5bfa 0x5bfa added the bug Something isn't working label Mar 7, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the needs-triage Issue needs to be triaged by the area owners label Mar 7, 2024
@codendone codendone added area-Menus team-Controls Issue for the Controls team fixed-internally This bug has been fixed, and the fix will be shipped in the next version of WinUI 3. Regression and removed needs-triage Issue needs to be triaged by the area owners labels Mar 7, 2024
@codendone codendone added this to the WinAppSDK 1.5 milestone Mar 7, 2024
@codendone
Copy link
Contributor

Fixed in the upcoming 1.5.1 servicing release.

@0x5bfa 0x5bfa closed this as completed Mar 7, 2024
@0x5bfa
Copy link
Author

0x5bfa commented Mar 13, 2024

This is not fixed at all.
Let me know how you fixed and verified to have fixed?

There's an example app that can repro this issue.
https://github.com/files-community/Files
Upgrade the version in Files.App.csproj file to repro.

@0x5bfa 0x5bfa reopened this Mar 13, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the needs-triage Issue needs to be triaged by the area owners label Mar 13, 2024
@yaira2
Copy link
Contributor

yaira2 commented Mar 13, 2024

More specifically, this issue occurs when the menu item is hidden and then made visible later. The issue does not occur when the item is visible from the start.

@codendone codendone removed needs-triage Issue needs to be triaged by the area owners fixed-internally This bug has been fixed, and the fix will be shipped in the next version of WinUI 3. labels Mar 13, 2024
@codendone codendone removed this from the WinAppSDK 1.5 milestone Mar 13, 2024
@codendone
Copy link
Contributor

The scenario @yaira2 mentioned is exactly what the fix was for, but it sounds like the fix wasn't complete.

@llongley
Copy link
Member

There's an example app that can repro this issue. https://github.com/files-community/Files Upgrade the version in Files.App.csproj file to repro.

@0x5bfa Could you provide more specific repro steps using this app? I've brought up the right-click menu in multiple places, but I haven't yet been able to see this repro with the latest version of the Microsoft.WindowsAppSDK NuGet package.

@yaira2
Copy link
Contributor

yaira2 commented Mar 14, 2024

Try right clicking a photo

@0x5bfa
Copy link
Author

0x5bfa commented Mar 14, 2024

  1. Select an item
  2. Right click

In the latest commit, this icon is already hidden to publish a release to the public. Please check out to the Upgrading commit first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Menus bug Something isn't working Regression team-Controls Issue for the Controls team
Projects
None yet
Development

No branches or pull requests

4 participants