Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Update hover visual #953

Closed
sravya03 opened this issue Jun 26, 2019 · 8 comments · Fixed by #1171
Closed

Proposal: Update hover visual #953

sravya03 opened this issue Jun 26, 2019 · 8 comments · Fixed by #1171
Assignees
Labels
area-Styling area-UIDesign UI Design, styling feature proposal New feature proposal team-Controls Issue for the Controls team
Milestone

Comments

@sravya03
Copy link

sravya03 commented Jun 26, 2019

Summary

Update the hover visual to align more with the depth model. When item is hovered over, the item is lifted. When you get closer to the item, the color becomes lighter.

Rationale

  • The button today indicates hover via grid border lines. Removed the border and using color is more coherent and consistent.
  • Follows the other control updates being proposed.

Important Notes

Here are the scoped changes proposed. Ones with asterisk are places where change is proposed.
image

Controls impacted:

  • Button
  • ToggleButton
  • Checkbox
  • SplitButton
  • ToggleButton
  • ToggleSplitButton

Buttons   Hyperlinks

Buttons   Hyperlinks - Dark Theme

@sravya03 sravya03 added the feature proposal New feature proposal label Jun 26, 2019
@msft-github-bot msft-github-bot added this to Freezer in Feature tracking Jun 26, 2019
@msft-github-bot msft-github-bot added this to Needs triage in Controls Triage Jun 26, 2019
@mdtauk
Copy link
Contributor

mdtauk commented Jun 26, 2019

Fluent Web uses this elevate on hover design. Take a look at the Microsoft Store app pages

@chigy chigy added this to New in Visual update Jun 26, 2019
@mdtauk
Copy link
Contributor

mdtauk commented Jun 27, 2019

buttons

Here is a look at 4 different Microsoft buttons using Fluent Design.

And on the right is an idea how you could blend those ideas into a new design

@jevansaks jevansaks added the area-UIDesign UI Design, styling label Jun 27, 2019
@jevansaks jevansaks moved this from Needs triage to Backlog in Controls Triage Jun 27, 2019
@chigy chigy moved this from New to Waiting on design in Visual update Jun 28, 2019
@chigy
Copy link
Member

chigy commented Jul 15, 2019

Status update

This proposal is being closed in favor of the another proposal (#1054) that was created that better defines the scope of the ask.

BTW, I do believe the other proposal does cover the suggestion @mdtauk mentioned in one of the feedback.

@mdtauk , @sravya03 FYI

@chigy chigy closed this as completed Jul 15, 2019
Controls Triage automation moved this from Backlog to Closed Jul 15, 2019
@msft-github-bot msft-github-bot removed this from Freezer in Feature tracking Jul 15, 2019
@chigy chigy moved this from Waiting on design to WinUI 2.2 in Visual update Jul 19, 2019
@chigy chigy reopened this Jul 30, 2019
@msft-github-bot msft-github-bot added this to Freezer in Feature tracking Jul 30, 2019
@chigy
Copy link
Member

chigy commented Jul 30, 2019

Status update

Re-opening this because more systematic update to the button (#1054) was tabled but we still want to do the visual update to remove the border during hover state in WinUI2.2 to bring the design more in line to be more coherent and familiar. This change and #839 should be done together to align the design amongst the set of controls.

@mdtauk
Copy link
Contributor

mdtauk commented Aug 22, 2019

@chigy Is there a rationale why the Slider hover is the Theme Base High colour, and not Accent Light 1/2 like with the hover on the Accent coloured Button/Checkbox/RadioButton/ToggleSwitch?

@chigy
Copy link
Member

chigy commented Aug 22, 2019

@mdtauk , you should open it as a proposal or idea. For this change, we are minimizing impact by not touching controls other than button related since we are trying to target WinUI2.2 release which is coming up shortly.

@mdtauk
Copy link
Contributor

mdtauk commented Aug 22, 2019

@chigy #1193 Done

@msft-github-bot
Copy link
Collaborator

🎉This issue was addressed in #1171, which has now been successfully released as Microsoft.UI.Xaml v2.2.190822001-prerelease.:tada:

Handy links:

@jevansaks jevansaks added the team-Controls Issue for the Controls team label Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Styling area-UIDesign UI Design, styling feature proposal New feature proposal team-Controls Issue for the Controls team
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

5 participants