-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up the footer #55
Comments
+1 |
@martinwoodward Are the colors from an internal style guide or would you be open to a pull request with a rework that addresses the issue with the white footer following the colored ones? |
Were there other people pulls associated to this? Or just closing due to age? |
N30 |
What about November 30th? |
Kevin, we're closing these out due to age mostly, there's a larger effort to launch a more dynamic index of Microsoft Open Source over at https://opensource.microsoft.com, instead of the rather manual updates that were happening to this site in the past. Do let us know if anything here seems super urgent! |
Sounds good. Thanks for the information. I'll look over this tonight! |
Currently, it looks like there are three separate "footers" on the page. The first two (with the light blue and the bolder blue backgrounds) aren't bad, but the third (white background) makes the layout look "broken" since it switches back to a white background, has a smaller width than the second one, and has a lot of content that looks like it was randomly tossed together.
A larger (single) footer, such as the one on microsoft.com, might work better than the current "second" and "third" footers, but it really depends on how the content is organized.
The open source line (the
credits
div) also stands out since it's much longer than anything else in that section, and it also bumps the content on the right side of the footer down so that it is no longer even with the content on the left. It could possibly be placed after the "Microsoft"-esque footer, and maybe centered on the page.The text was updated successfully, but these errors were encountered: