Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create abstract interface for RecyclableMemoryStreamManager #6

Closed
cd21h opened this issue Mar 16, 2015 · 1 comment
Closed

Create abstract interface for RecyclableMemoryStreamManager #6

cd21h opened this issue Mar 16, 2015 · 1 comment

Comments

@cd21h
Copy link

cd21h commented Mar 16, 2015

Please create abstract interface for RecyclableMemoryStreamManager public surface to facilitate unit-testing.

@doubleyewdee
Copy link
Contributor

After discussing this with Ben we are going to avoid doing this. There are a lot of great mocking libraries that should obviate the need for an interface here, and unfortunately adding interfaces is a non-zero performance cost for every call site. For users who do wish to mock via interfaces or use separate implementations our recommendation would be to create and provide your own wrappers since this is a pretty simple library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants