Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCDLPComplianceRule : Complexe rules are not saved/managed #3845

Open
pkernevez opened this issue Oct 27, 2023 · 2 comments
Open

SCDLPComplianceRule : Complexe rules are not saved/managed #3845

pkernevez opened this issue Oct 27, 2023 · 2 comments
Labels
Bug Something isn't working Security & Compliance Center V1.23.1025.1 Version 1.23.1025.1

Comments

@pkernevez
Copy link
Contributor

Description of the issue

When defined a compliance rule.
When running the command 'Get-DlpComplianceRule' it returns:

ContentContainsSensitiveInformation          :     <== Empty
AdvancedRule                                 : {
                                                 "Version": "1.0",
                                                 "Condition": {
                                                   "Operator": "And",
                                                   "SubConditions": [
                                                     {
                                                       "ConditionName": "ContainsSensitiveInformation",
                                                       "Value": [
                                                         {
                                                           "Groups": [
                                                             {
                                                               "Name": "RuleOn-Email - medium",
                                                               "Operator": "Or",
                                                               "Sensitivetypes": [
                                                                 {
                                                                   "Name": "RuleOn-Email",
                                                                   "Id": "123345-b316-678-6789-1233387878",
                                                                   "Mincount": 1,
                                                                   "Maxcount": 3,
                                                                   "Confidencelevel": "Medium",
                                                                   "Minconfidence": 75,
                                                                   "Maxconfidence": 100
                                                                 }
                                                               ]
                                                             }
                                                           ],
                                                           "Operator": "And"
                                                         }
                                                       ]
                                                     }
                                                   ]
                                                 }
                                               }

The Dsc365 module is only dealing with the field 'ContentContainsSensitiveInformation'.

In our case the export is empty (no rule) et updating erase the configuration.

The sensitivity type is a custom one.

I don't find what is exactly decide to not create the hashmap ContentContainsSensitiveInformation but our case it's a big issue.

May should we replace ContentContainsSensitiveInformation fields with AdvancedRule that is supported in the xxx-DlpComplianceRule commands.
But it could be a breaking change.

Microsoft 365 DSC Version

1.23.1018.1 & 1.23.1025.1

Which workloads are affected

Security & Compliance Center

The DSC configuration

No response

Verbose logs showing the problem

No response

Environment Information + PowerShell Version

No response

@andikrueger andikrueger added Bug Something isn't working Security & Compliance Center V1.23.1025.1 Version 1.23.1025.1 labels Nov 2, 2023
@pkernevez
Copy link
Contributor Author

Hello,
An idea of how addressing the issue ?
I may work on it, but I would like to know the direction you want to follow.

@andikrueger
Copy link
Collaborator

In this instance, I would add a null check for both properties. Is there any chance to add these in a meaningful way into the current parameter set?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Security & Compliance Center V1.23.1025.1 Version 1.23.1025.1
Projects
None yet
Development

No branches or pull requests

2 participants