Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allocation overriding on Windows with CMake #85

Open
seanmiddleditch opened this issue Jul 7, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@seanmiddleditch
Copy link

commented Jul 7, 2019

The file alloc-override-win.c is never included or built on Windows when using CMake. It appears that the file is only referenced at all in the provided .vcxproj files, which are not of help to parent CMake projects that are building via add_subdirectory (and may not even be using MSBuild anyway but rather Ninja, which is also the default CMake build system in Visual Studio itself these days).

@daanx

This comment has been minimized.

Copy link
Collaborator

commented Jul 8, 2019

Ah yes. I never used cmake yet to build on windows but always use the Visual Studio solution. We need to add some rules to build this correctly on Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.