Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.1.4 and error mingw/msys2 #884

Closed
3rav opened this issue Apr 24, 2024 · 4 comments
Closed

2.1.4 and error mingw/msys2 #884

3rav opened this issue Apr 24, 2024 · 4 comments

Comments

@3rav
Copy link

3rav commented Apr 24, 2024

I have this error with 2.1.4 (2.1.2 was OK)

 -- Library base name: mimalloc
  -- Version          : 2.1
  -- Build type       : release
  -- C Compiler       : D:/M/msys64/mingw64/bin/gcc.exe
  -- Compiler flags   : -Wall;-Wextra;-Wno-unknown-pragmas;-fvisibility=hidden;-Wstrict-prototypes;-ftls-model=initial-exec;-fno-builtin-malloc
  -- Compiler defines : 
  -- Link libraries   : psapi;shell32;user32;advapi32;bcrypt
  -- Build targets    : shared;static
  -- 
  -- Configuring done (0.9s)
  -- Generating done (0.0s)
  -- Build files have been written to: C:/_/B/src/build-MINGW64
  ninja: error: 'C:/_/B/src/mimalloc-2.1.4/bin/mimalloc-redirect.lib', needed by 'libmimalloc.dll', missing and no known rule to make it
  ==> ERROR: A failure occurred in build().
      Aborting...
  ==> Removing installed dependencies...
  checking dependencies...
@daanx
Copy link
Collaborator

daanx commented Apr 27, 2024

ah, that is strange -- I don't think anything changed here with cmake?
Maybe try to use make instead of ninja to build?

@AlifianK
Copy link

AlifianK commented May 5, 2024

v2.1.4 tag doesn't contain bin folder, which is present in v2.1.2. If you look in the bin folder, you'll see that it contains the required .lib file.
@daanx perhaps you forget to include that?

Further clarifying what I said, the tag I mentioned is from Github Releases, not the git branch. The git branch still contains bin folder.

@daanx
Copy link
Collaborator

daanx commented May 6, 2024

Mmm, very strange -- maybe a merge error. Thanks for reporting this, I'll fix it with the release update later this week.

@daanx
Copy link
Collaborator

daanx commented May 31, 2024

This is fixed now with v2.1.7. (it was an error in the .gitattributes)

@daanx daanx closed this as completed May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants