Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

Disposing a DiscoveryTask from its handler may cause deadlock #83

Closed
fibann opened this issue Oct 3, 2019 · 0 comments
Closed

Disposing a DiscoveryTask from its handler may cause deadlock #83

fibann opened this issue Oct 3, 2019 · 0 comments
Assignees
@fibann
Labels
bug Something isn't working Matchmaking Label for Matchmaking related work.
Milestone
Matchmaking Previ...

Comments

@fibann
Copy link
Member

fibann commented Oct 3, 2019 •
edited

If the task is the only one running, disposing it will call network_.Stop() which will wait for the receiving thread to be finished - but the receiving thread is the one executing the handler.
This should be documented, raise a hard error, or work as expected.
@fibann fibann added the Matchmaking Label for Matchmaking related work. label Oct 3, 2019
@fibann fibann added the bug Something isn't working label Dec 3, 2019
@fibann fibann added this to the Matchmaking Preview release milestone Jan 17, 2020
@fibann fibann self-assigned this Jan 22, 2020
fibann added a commit to fibann/MixedReality-Sharing that referenced this issue Jan 23, 2020
@fibann
Move resource updates to different thread
d91bd00 
This fixes microsoft#83, frees the receiving thread, and batches multiple updates
arriving in a short time span.
@fibann fibann closed this as completed in ccef0cc Jan 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@fibann fibann

Labels
bug Something isn't working Matchmaking Label for Matchmaking related work.
Projects
None yet
Milestone
Matchmaking Preview release
Development

No branches or pull requests
1 participant
@fibann