Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create unified Spatial Mapping Components #4

Closed
jim-wordelman-msft opened this issue Mar 29, 2016 · 0 comments
Closed

Create unified Spatial Mapping Components #4

jim-wordelman-msft opened this issue Mar 29, 2016 · 0 comments

Comments

@jim-wordelman-msft
Copy link

We should have components to handle rendering and creating colliders for spatial mapping.

These components should be usable by default but customizable to what most people need. Additionally, we should have heuristics to handle Tracking Lost and moving far away from a placed observer intelligently instead of just removing the meshes.
jim-wordelman-msft added a commit that referenced this issue Mar 29, 2016
@jim-wordelman-msft
Add unified Spatial Mapping Components
c17d143 
This adds two components: SpatialMappingCollider and
SpatialMappingRenderer. These components provide intelligent defaults
and follow best practices for handling Spatial Mapping.

Additionally, these components are customizable and implement heuristics
that better support tracking loss or moving far away from an observed
region.

Additionally

 - Move Wireframe and Occlusion shaders and materials to
   Resources/HoloToolkit for default loading in the components

 - Add section to README.md describing these components and update
   existing SpatialMapping section to suggest using the components by
   default.

This fixes #4
@jim-wordelman-msft jim-wordelman-msft mentioned this issue Mar 29, 2016
Merged
@NeerajW NeerajW closed this as completed in #5 Apr 6, 2016
NeerajW pushed a commit that referenced this issue Sep 26, 2016
Merge pull request #4 from Microsoft/master
3846862 
Merge pull request #237 from HodgsonSDAS/MSFT_Holotoolkit-master
StephenHodgson pushed a commit that referenced this issue Jan 7, 2017
@AsoboStudioPersonal
Merge pull request #4 from manudoulut/master
1be7e5a 
remove needless PlayEvent(key) & StopEvent(key) on awake
StephenHodgson pushed a commit that referenced this issue Jul 24, 2017
@waynebaby
Merge pull request #4 from Microsoft/master
ffbe05b 
Up to date
keveleigh referenced this issue in keveleigh/HoloToolkit-Unity Aug 11, 2017
@waynebaby @keveleigh
Merge pull request #4 from Microsoft/master
cb5c76c 
Up to date
keveleigh pushed a commit that referenced this issue Jul 10, 2018
Merge pull request #4 from SimonDarksideJ/vNext-Boundary_WithSelector
9c5b000 
V next boundary with selector
Ecnassianer added a commit that referenced this issue Oct 4, 2018
@Ecnassianer
Merge pull request #4 from Microsoft/mrtk_development
3e190d4 
update mrtk_development
thalbern added a commit that referenced this issue Mar 25, 2019
@thalbern
Merge pull request #4 from Microsoft/mrtk_development
c36b550 
Mrtk development
chrisfromwork added a commit that referenced this issue Mar 28, 2019
@chrisfromwork
Merge pull request #4 from chrisfromwork/spectatorViewMRTK
5cef16a 
MRTK example scene and MRTK configuration related fixes
@genereddick genereddick mentioned this issue Apr 12, 2019
Closed
ryantrem pushed a commit to ryantrem/MixedRealityToolkit-Unity that referenced this issue Apr 22, 2019
Merge pull request microsoft#4 from andreiborodin/features/anborod/as…
a6f1206 
…setRetargettingTest

Features/anborod/asset retargetting test
julenka pushed a commit that referenced this issue May 13, 2019
@djohnsomsft
Merge pull request #4 from microsoft/mrtk_development
b19ba41 
Merge from base
keveleigh pushed a commit that referenced this issue Jun 6, 2019
@sostel
Merge pull request #4 from Microsoft/mrtk_development
902e3e5 
Mrtk development
@wiwei wiwei mentioned this issue Jul 19, 2019
Merged
wiwei added a commit that referenced this issue Jul 22, 2019
@wiwei
Fixes gesture pinch release mechanics involving two mouse button inte…
1a42d70 
…ractions.

Prior to this fix, when using gestures (GGV) style interactions, you would run into this bug:

1) Press space bar to engage the hand simulation.
2) Hold down left mouse to engage pinch.
3) Hold down the right mouse to rotate the camera.
4) Lift the left mouse to disengage pinch.

Step #4 wouldn't work (it would stay engaged in the pinch until you lifted the right mouse button) because the existing code would see that the right mouse button was down, and even though it was not configured to do anything (i.e. a configuration of "none" means "don't affect the state of the gesture simulation"). However because the function returned "none", this told the rest of the code to keep doing what it was doing before (which was, simulating the pinch gesture associated with the left mouse click.)

You have to return the default (or open) pose explicitly to get the hand to open, and by making the code change to actually honor the lack of configuration, this all works out.
@ritijain ritijain mentioned this issue Oct 9, 2019
Merged
keveleigh pushed a commit that referenced this issue Dec 19, 2019
@artsouflMS
Merge pull request #4 from microsoft/mrtk_development
61ef619 
Mrtk development
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jim-wordelman-msft