Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeout to CI checks #40

Closed
bpkroth opened this issue Sep 2, 2020 · 1 comment
Closed

Add timeout to CI checks #40

bpkroth opened this issue Sep 2, 2020 · 1 comment

Comments

@bpkroth
Copy link
Contributor

bpkroth commented Sep 2, 2020

A python unit test failed in Github Action pipeline, but it took a long time:
https://github.com/microsoft/MLOS/pull/29/checks?check_run_id=1061557146#step:9:41362

We should see about controlling that with some timeouts.

@bpkroth
Copy link
Contributor Author

bpkroth commented Sep 2, 2020

As mentioned by @edcthayer this could also just be due to that particular run selecting a particularly complex polynomial that took longer to execute.

We could fix that individual check to restrict the polynomial complexity, but we should probably also set explicit limits on CI checks if we can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant