Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reevaluate use of getcwd in python code #74

Closed
bpkroth opened this issue Sep 11, 2020 · 1 comment
Closed

Reevaluate use of getcwd in python code #74

bpkroth opened this issue Sep 11, 2020 · 1 comment

Comments

@bpkroth
Copy link
Contributor

bpkroth commented Sep 11, 2020

There are several places where getcwd is used to compose a path assuming that the script is executed from the source/Mlos.Python directory or else used to create a temporary file.

For the first, we should change it to be relative to the file referencing it so that the script can be executed from a different directory.

For the second, we should be using the system provided get temp files to avoid security issues.

@bpkroth
Copy link
Contributor Author

bpkroth commented Sep 15, 2020

Here's an example: b47737a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant