Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] Some workshops cannot be found through search engine #68

Open
lgmorand opened this issue Aug 25, 2023 · 5 comments
Open

[Issue] Some workshops cannot be found through search engine #68

lgmorand opened this issue Aug 25, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@lgmorand
Copy link
Contributor

https://github.com/microsoft/moaw/blob/main/packages/database/external.yml#L121

How can it be not listed ? even without the search engine

@lgmorand
Copy link
Contributor Author

some other workshops are missing. something is wrong with building the DB

@lgmorand
Copy link
Contributor Author

it seems that it comes from the lang filter but I don't have UI to change it.

https://moaw.dev/catalog/?lang=fr

@sinedied
Copy link
Collaborator

Yes currently the language filter is implemented but the UI to switch languages and show the different available languages for a workshop is not built yet, that's something I need to work on. As a workaround, you can use this URL https://moaw.dev/catalog/?lang=all to display all workshops regardless of the language

@lgmorand
Copy link
Contributor Author

Should the UI should consider language = "all" is not parameter is set ?

@sinedied
Copy link
Collaborator

It's usually weird to see content listed which is not your primary languages (some workshop are in portuguese for example) and it would be a bit messy to have it as the default.
The 'all' value was added more as a temporary workaround for not having a built-in language selector.
Adding the language selector was next on my priority list, but unfortunately I have urgent requests on other projects that keeps adding, so I won't be able to work on that anytime soon

@sinedied sinedied added the enhancement New feature or request label Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants