Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use vscode-html-languageservice options to allow custom elements #1723

Closed
bioub opened this issue Dec 27, 2018 · 2 comments
Closed

Use vscode-html-languageservice options to allow custom elements #1723

bioub opened this issue Dec 27, 2018 · 2 comments
Assignees
Labels
feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities html
Milestone

Comments

@bioub
Copy link

bioub commented Dec 27, 2018

I'm thinking of the easiest way to supports collections of custom elements.

vscode-html-languageservice offers the ability to register custom tags and attributes here :
https://github.com/Microsoft/vscode-html-languageservice/blob/62efc4b0768640e0c1f5f67974205e0c4abbfaf7/src/htmlLanguageService.ts#L46

What would you think about adding and option to htmlDefaults like this ?

monaco.languages.html.htmlDefaults.setOptions({
  customTags: {
    'staytuned-player': {
      label: 'Staytuned.io podcast player',
      attributes: ['src', 'fixed'],
    },
  },
});

Tell me if you'd like me to do the PR.

@octref
Copy link

octref commented Jan 23, 2019

Keep in mind the html-languageservice API is not finalized yet...

@alexdima alexdima transferred this issue from microsoft/monaco-html Dec 20, 2019
@alexdima alexdima added feature-request Request for new features or functionality html labels Dec 20, 2019
@alexdima alexdima added this to the Backlog milestone Dec 20, 2019
@aeschli aeschli added the help wanted Issues identified as good community contribution opportunities label Jun 4, 2021
@aeschli aeschli self-assigned this Jun 4, 2021
@aeschli
Copy link
Contributor

aeschli commented Jun 11, 2021

duplicate of #2284

I added new API to allow configuring the HTML and CSS language supports with custom data.
See #2284 (comment) for details.

@aeschli aeschli closed this as completed Jun 11, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities html
Projects
None yet
Development

No branches or pull requests

4 participants