Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] getWorker method type is too restrictive #2986

Closed
2 tasks done
CGNonofr opened this issue Feb 22, 2022 · 0 comments · Fixed by microsoft/vscode#143611
Closed
2 tasks done

[Feature Request] getWorker method type is too restrictive #2986

CGNonofr opened this issue Feb 22, 2022 · 0 comments · Fixed by microsoft/vscode#143611
Labels
feature-request Request for new features or functionality

Comments

@CGNonofr
Copy link
Contributor

Context

  • This issue is not a bug report. (please use a different template for reporting a bug)
  • This issue is not a duplicate of an existing issue. (please use the search to find existing issues)

Description

The Environment.getWorker function is expected to return a Worker, while the current code is already able to work with a Promise<Worker>
@CGNonofr CGNonofr added the feature-request Request for new features or functionality label Feb 22, 2022
@CGNonofr CGNonofr mentioned this issue Feb 22, 2022
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Apr 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature-request Request for new features or functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow getWorker function to return a promise CodinGame/vscode
1 participant
@CGNonofr