Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefined and null values are not properly handled #3414

Closed
felixlheureux opened this issue Nov 7, 2022 · 1 comment
Closed

Undefined and null values are not properly handled #3414

felixlheureux opened this issue Nov 7, 2022 · 1 comment
Assignees
Labels
under-discussion Issue is under discussion for relevance, priority, approach
Milestone

Comments

@felixlheureux
Copy link

felixlheureux commented Nov 7, 2022

  • VS Code Version: Current
  • OS Version: MacOS Ventura

Undefined and null values are not properly handled. When an undefined value is passed in Monaco, the textModel will call factory.create on an undefined value which will throw an undefined error.

Also, if a null value is passed, since the logic returns without updating the value, the previous data will still be displayed.

Solution here: microsoft/vscode#165721

Steps to Reproduce:

  1. Update the data to undefined or null once the Monaco editor is already mounted.
@alexdima alexdima added the under-discussion Issue is under discussion for relevance, priority, approach label Nov 14, 2022
@alexdima alexdima transferred this issue from microsoft/vscode Nov 14, 2022
@hediet
Copy link
Member

hediet commented Dec 13, 2022

Fixed with your PR. Thanks!

@hediet hediet closed this as completed Dec 13, 2022
@hediet hediet added this to the January 2023 milestone Dec 13, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests

3 participants