Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Regression - diff glyphs no longer render in the correct position #4550

Open
1 of 2 tasks
oodavid opened this issue Jun 6, 2024 · 0 comments
Open
1 of 2 tasks

Comments

@oodavid
Copy link

oodavid commented Jun 6, 2024

Reproducible in vscode.dev or in VS Code Desktop?

  • Not reproducible in vscode.dev or VS Code Desktop

Reproducible in the monaco editor playground?

Monaco Editor Playground Link

Works in 0.47.0

https://microsoft.github.io/monaco-editor/playground.html?source=v0.47.0#XQAAAAISAwAAAAAAAABBqQkHQ5NjdMjwa-jY7SIQ9S7DNlzs5W-mwj0fe1ZCDRFc9ws9XQE0SJE1jc2VKxhaLFIw9vEWSxW3yscw22pmyAEiAJM8XEuX7Os378jBGtVLkr6ryuhqvky-XZ9Sy0vyFSI1m9lYQpwqOsaKmhydYWIo-9hGbv_4wlPISElp-VESf2nBVKMFZt4gq-ac4Y2IV2CyX-xtlzx7MkURa4qA_-E3aRVIZMlg4ytMiDOhYYa4rRsbPMLPAyelzc3xs-BbfFU2xDMWv5TQrOqkYVWwQU_XsFUYiLdjGb4ujnplQV2xOoA4gp2xwpumLZIaP8W5h2vvTum6rkt56Fiqi19KYLMZP4dGd95K6D_rYNw0hOJjuZ1notwbklOecOtKUDhcly1bVBPUhWYFUaa14-IqzsrmsIjVfq5UGZsyADpDz8b7Suggu4uw1SBm1JdBo4p-ugT85c5xOxoO36rhoK8RuIFQsup3F_EhgoQrVdxgYlnijkgMFZ4jb47eRE4SnyzRCY9jQ0uSDHCgYygeSrqPt3sIjKufaH40oaIXSIQFOZSyhBPe_vhDKxk

Breaks in 0.48.0 (and later)

https://microsoft.github.io/monaco-editor/playground.html?source=v0.48.0#XQAAAAISAwAAAAAAAABBqQkHQ5NjdMjwa-jY7SIQ9S7DNlzs5W-mwj0fe1ZCDRFc9ws9XQE0SJE1jc2VKxhaLFIw9vEWSxW3yscw22pmyAEiAJM8XEuX7Os378jBGtVLkr6ryuhqvky-XZ9Sy0vyFSI1m9lYQpwqOsaKmhydYWIo-9hGbv_4wlPISElp-VESf2nBVKMFZt4gq-ac4Y2IV2CyX-xtlzx7MkURa4qA_-E3aRVIZMlg4ytMiDOhYYa4rRsbPMLPAyelzc3xs-BbfFU2xDMWv5TQrOqkYVWwQU_XsFUYiLdjGb4ujnplQV2xOoA4gp2xwpumLZIaP8W5h2vvTum6rkt56Fiqi19KYLMZP4dGd95K6D_rYNw0hOJjuZ1notwbklOecOtKUDhcly1bVBPUhWYFUaa14-IqzsrmsIjVfq5UGZsyADpDz8b7Suggu4uw1SBm1JdBo4p-ugT85c5xOxoO36rhoK8RuIFQsup3F_EhgoQrVdxgYlnijkgMFZ4jb47eRE4SnyzRCY9jQ0uSDHCgYygeSrqPt3sIjKufaH40oaIXSIQFOZSyhBPe_vhDKxk

Monaco Editor Playground Code

const originalModel = monaco.editor.createModel(
    '\n\nhello world\n\n\n\nTesting\n\nTest',
    'text/plain'
);
const modifiedModel = monaco.editor.createModel(
    'Hello World!\n\n\n\nTesting\n\nHi',
    'text/plain'
);

const diffEditor = monaco.editor.createDiffEditor(
    document.getElementById("container"),
    {
        glyphMargin: true,
    }
);
diffEditor.setModel({
    original: originalModel,
    modified: modifiedModel,
});

Reproduction Steps

Use a diffEditor with glyphMargin: true in v0.48.0 or later

Actual (Problematic) Behavior

v0.48.0 - the diff glyphs do not render alongside each diff. Instead they are all at the top of the gutter.

Screenshot 2024-06-06 at 16 45 53

Expected Behavior

v0.47.0 correctly shows the glyphs alongside each diff

Screenshot 2024-06-06 at 16 46 46
@oodavid oodavid changed the title [Bug] [Bug] Reversion - diff glyphs no longer render in the correct position Jun 6, 2024
@oodavid oodavid changed the title [Bug] Reversion - diff glyphs no longer render in the correct position [Bug] Regression - diff glyphs no longer render in the correct position Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant