Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect YAML highlighting after value with two opening curly braces #786

Closed
cmeury opened this issue Mar 22, 2018 · 6 comments
Closed

Comments

@cmeury
Copy link

cmeury commented Mar 22, 2018

monaco-editor version: VSCode 1.21.1
OS: macOS High Sierra 10.13.3

This minimal YAML file:

key1: highlighted
key2: "{{"
key3: not-highlighted

is highlighted incorrectly, while it looks like valid YAML.

screen shot 2018-03-22 at 13 53 56

@rcjsuen
Copy link
Contributor

rcjsuen commented Mar 22, 2018

@cmeury It looks okay on the website to me.

image

@cmeury
Copy link
Author

cmeury commented Mar 22, 2018

Looks like it. Is there a large difference in progress between VSCode and the monaco-editor component? How do I find out what version of the editor my VSCode installation uses?

@rcjsuen
Copy link
Contributor

rcjsuen commented Mar 22, 2018

@cmeury Well, the reality is that VS Code uses a TextMate grammar whereas Monaco uses Monarch tokens so they're not really the same thing.

@rcjsuen
Copy link
Contributor

rcjsuen commented Mar 22, 2018

@cmeury I think you should open a bug in the Microsoft/vscode repository.

@rcjsuen
Copy link
Contributor

rcjsuen commented Mar 22, 2018

@cmeury Actually, Martin already opened a bug about your exact problem! See textmate/yaml.tmbundle#18!

@cmeury
Copy link
Author

cmeury commented Mar 22, 2018

Thanks for the background and pointing me in the right direction @rcjsuen, much appreciated. Closing this one.

@cmeury cmeury closed this as completed Mar 22, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants